Feature: Split test smaller lesson content font size. #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: * We are forcing larger font size on all users when it should be left as a choice. * Larger text accentuates and makes other things harder to get right - it had a part to play in the difficulty styling our links. This commit: * Experiment with using a baseline 16px font size. * Only 50% of users will see it so we can monitor feedback. * The best feedback for this is probably no feedback. The right font size is table stakes, if no one notices the change it will likely be a good thing.
KevinMulhern
added
the
Type: Enhancement
ChargrilledChook
approved these changes
Jul 16, 2023
Comment on lines
+10
to
+16
| attr_reader :classes, :data_attributes, :current_user | ||
|
|
||
| def font_size | ||
| return '' if current_user && Feature.enabled?(:lesson_content_font_size, current_user) | ||
|
|
||
| 'md:prose-lg' | ||
| end |
There was a problem hiding this comment.
Should we follow up and revert this if the experiment is successful?
There was a problem hiding this comment.
Yep, thats a great idea 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
When enabled:
When disabled (the default):
This commit: