Feature: Moving project solutions to Hotwire final tweaks #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMulhern
force-pushed
the
feature/hotwire-submission-tweaks
branch
from
5aa2e97
to
4f06165
Compare
Because: * A few final touches before we start rolling this out to users. This commit: * Move the add solution button hook outside of the current users solution conditional - this is needed for the button to display correctly when the user deletes their solution after refreshing the page. * Change "Add submission" button text to "Add solution" - to fit the solutions title. * Add a hidden class to the drop down so it does not flash visible for a brief moment during re-render
KevinMulhern
force-pushed
the
feature/hotwire-submission-tweaks
branch
from
4f06165
to
33de9f3
Compare
KevinMulhern
added
the
Type: Enhancement
ChargrilledChook
approved these changes
Jul 12, 2023
| @@ -24,7 +24,7 @@ | |||
| data-transition-leave="transition ease-in duration-75" | |||
| data-transition-leave-start="transform opacity-100 scale-100" | |||
| data-transition-leave-end="transform opacity-10 scale-95" | |||
| class="absolute right-0 z-10 mt-2 w-32 origin-top-right rounded-md bg-white dark:bg-gray-700 py-2 shadow-lg ring-1 ring-gray-900/5 dark:ring-gray-300/5 focus:outline-none" role="menu" aria-orientation="vertical" aria-labelledby="options-menu-0-button" tabindex="-1"> | |||
| class="hidden absolute right-0 z-10 mt-2 w-32 origin-top-right rounded-md bg-white dark:bg-gray-700 py-2 shadow-lg ring-1 ring-gray-900/5 dark:ring-gray-300/5 focus:outline-none" role="menu" aria-orientation="vertical" aria-labelledby="options-menu-0-button" tabindex="-1"> | |||
There was a problem hiding this comment.
What controls the un-hiding of this element? Probably something obvious but it's not jumping out at me
There was a problem hiding this comment.
Good question and no worries, it's not that obvious. The visibility stimulus controller is unhiding via el-transistion. It toggles the hidden class and add transitions under the hood.
| @@ -41,7 +41,7 @@ | |||
| expect(page).to have_content(user.username) | |||
| end | |||
|
|
|||
| expect(page).not_to have_content('Add submission') | |||
| expect(page).not_to have_content('Add solution') | |||
There was a problem hiding this comment.
Have made some comments on #3955 but not a blocker for this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: