Feature: Liking project submissions with Hotwire #3929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMulhern
force-pushed
the
feature/like-submissions-with-hotwire
branch
from
4693700
to
eacefe5
Compare
KevinMulhern
force-pushed
the
feature/like-submissions-with-hotwire
branch
from
eacefe5
to
f3a109b
Compare
Because: * We are moving our React components to Hotwire This commit: * Add like view component to encapsulate the like button. * Add like singular resource route and controller - now with a proper delete route instead of reusing the create action. * Decorates submissions with current user likes when they are being fetched. This saves us from checking each one individually and hitting the database each time. * Adds a reusable sorting stimulus controller - can be used to automatically sort lists on page load or when a list item changes.
KevinMulhern
force-pushed
the
feature/like-submissions-with-hotwire
branch
from
f3a109b
to
f3a5829
Compare
KevinMulhern
added
the
Type: Enhancement
KevinMulhern
commented
Jul 10, 2023
| @@ -1,52 +1,47 @@ | |||
| <%= turbo_frame_tag project_submission do %> | |||
| <div data-test-id="submission-item" class="relative py-6 border-solid border-t border-gray-300 flex flex-col md:flex-row justify-between items-center"> | |||
| <div id="<%= dom_id(project_submission) %>" data-id="<%= project_submission.id %>" data-sort-target="item" data-sort-code="<%= sort_by %>"> | |||
There was a problem hiding this comment.
Switched the turbo frame for a div because sortable.js cannot animate turbo frame elements.
| @@ -1,5 +1,7 @@ | |||
| module ProjectSubmissions | |||
| class ItemComponent < ApplicationComponent | |||
| CURRENT_USER_SORT_CODE = 10_000_000 # current user's submission should always be first | |||
There was a problem hiding this comment.
Bit of a workaround for now. After we get feature parity with the current submissions, we would be in a good place to revisit the design of submissions; and cleanly separate the users submission from the rest.
CouchofTomato
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: