Feature: Edit and Delete Submission with Hotwire #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New action menu for all submissions: |
Because: * We are moving our project submissions feature to Hotwire This commit: * Add action menu to every project submission. The users submission will display edit and delete links, everyone elses will have the report link (yet to be implemented) * Add edit and update actions/views for v2 project submissions * Add delete action for v2 project submissions
KevinMulhern
force-pushed
the
feature/hotwire-edit-submissions
branch
from
e1282e5
to
a049fae
Compare
|
Relates to: #3908 |
KevinMulhern
added
the
Type: Enhancement
| @@ -1,5 +1,5 @@ | |||
| <%= turbo_frame_tag 'project_submission_form', class: 'w-full' do %> | |||
| <%= form_with url: lesson_v2_project_submissions_path(lesson.id), model: project_submission, builder: TailwindFormBuilder do |form| %> | |||
| <%= form_with url:, model: project_submission, builder: TailwindFormBuilder do |form| %> | |||
There was a problem hiding this comment.
Nothing wrong with your code, but for a second I thought you'd accidentally left in url:. Not sure I like this Ruby feature 😆
There was a problem hiding this comment.
heh, it's been tripping me up too 😆. Final version of this will get rid of that url and just use the model object. I only need the url atm because of the v2 namespace.
CouchofTomato
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: