Feature: Use delete request with sign out #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMulhern
added
the
Type: Enhancement
ChargrilledChook
approved these changes
Jun 25, 2023
| @@ -28,7 +28,7 @@ | |||
| <%= render Theme::SwitcherComponent.new(current_theme:) %> | |||
| <% end %> | |||
|
|
|||
| <%= link_to sign_out_path, class: 'text-gray-700 dark:text-gray-300 group flex items-center px-3 py-2 text-sm' do %> | |||
| <%= link_to sign_out_path, class: 'text-gray-700 dark:text-gray-300 group flex items-center px-3 py-2 text-sm', data: { turbo_method: :delete } do %> | |||
There was a problem hiding this comment.
Would it be better to use button_to instead of link to to improve the semantics, as well? I know there are some considerations with how button_to wraps the button in a form, but could still be worthwhile
Because: * Using a get for something destructive like signing out is a security issue. Users could be made to unintentionally sign out if they clicked on a "https://theodinproject.com/sign_out" link someone sent them. This commit: * Change sign_out path to delete instead of a get request. * Refactor nav item component to take an options hash which we can use for the mobile flag and this new method option.
KevinMulhern
force-pushed
the
feature/use-delete-for-sign-out-links
branch
from
972f37d
to
b96bcab
Compare
ChargrilledChook
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: