Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update error pages to match modern TOP styling #3872

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

Asartea
Copy link
Contributor

@Asartea Asartea commented Jun 22, 2023

Because

  • The static error pages haven't been touched for more than a decade, and look wildly out of place among TOP's modern styling

This PR

Issue

Closes #3660

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behavior
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3872 June 23, 2023 13:09 Inactive
@KevinMulhern KevinMulhern self-requested a review June 25, 2023 15:12
@KevinMulhern KevinMulhern added the Type: Enhancement Involves a new feature or enhancement request label Jun 25, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3872 June 25, 2023 15:37 Inactive
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on this @Asartea, this is a huge improvement 🔥

I've left some feedback, mostly minor styling and wording changes. Happy to discuss any of it.

public/500.html Outdated Show resolved Hide resolved
public/500.html Outdated Show resolved Hide resolved
public/500.html Show resolved Hide resolved
public/500.html Outdated Show resolved Hide resolved
public/422.html Outdated Show resolved Hide resolved
public/500.html Show resolved Hide resolved
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3872 June 26, 2023 15:00 Inactive
@Asartea
Copy link
Contributor Author

Asartea commented Jun 26, 2023

Should all be done @KevinMulhern

@Asartea
Copy link
Contributor Author

Asartea commented Jun 26, 2023

I have no clue what is up with that failed test; given that I only made changes in /public I shouldn't be able to touch app code, and Rspec returns no errors when running locally on both main and my branch
Untitled

@KevinMulhern
Copy link
Member

All good @Asartea , it's nothing you've done, just a flaky test on CI - we've been getting them a lot lately 😓.

Rerunning the CI job now, that should sort it out.

Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 These look great, thank you for taking the time to do them @Asartea 💪

@KevinMulhern KevinMulhern merged commit f735b28 into TheOdinProject:main Jun 26, 2023
@Asartea Asartea deleted the update-error-pages branch June 26, 2023 16:54
@Asartea Asartea restored the update-error-pages branch July 15, 2023 07:45
@Asartea Asartea deleted the update-error-pages branch July 15, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Involves a new feature or enhancement request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

HTTP status code pages: update to match modern styling
2 participants