Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add Project Submissions With Hotwire #3852

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Feature: Add Project Submissions With Hotwire #3852

merged 1 commit into from
Jun 30, 2023

Conversation

KevinMulhern
Copy link
Member

Because:

  • We are converting project submissions from react to Hotwire.

This commit:

  • Add Hotwire modal
  • Display project submissions form partial when within the modal when adding a project
  • Redesign the project submission form, modern styling and clearer privacy controls.
  • Prepend users and hide the add submission button with a turbo stream
Screen.Recording.2023-06-16.at.02.38.06.mov

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3852 June 16, 2023 02:03 Inactive
@ChargrilledChook ChargrilledChook self-requested a review June 16, 2023 02:31
@KevinMulhern KevinMulhern self-assigned this Jun 19, 2023
@KevinMulhern KevinMulhern added the Type: Enhancement Involves a new feature or enhancement request label Jun 19, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3852 June 19, 2023 19:01 Inactive
@KevinMulhern
Copy link
Member Author

Just a reminder, this is behind a feature flag. Only displaying the list and adding is currently implemented. The rest will be down in subsequent PR's.

To enable the feature flag:

  1. Sign into /admin with one of the QA admin accounts
  2. Hover over the avatar in the top right
  3. Click "Feature flags"
  4. Click "add feature"
  5. Input "v2_project_submissions" and click "Add"
  6. Click the "fully enable" button

@KevinMulhern KevinMulhern force-pushed the feature/hotwire-add-project branch 2 times, most recently from 0fa9939 to 09b2978 Compare June 21, 2023 08:15
@KevinMulhern
Feature: Add Project Submissions With Hotwire
3d23235 
Because:
* We're converting project submissions from react to hotwire.

This commit:
* Add hotwire modal
* Display project submissions form partial when within the modal when adding a project
* Redesign the project submission form, modern styling and clearer privacy controls.
* Prepend users and hide the add submission button with a turbo stream
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3852 June 21, 2023 19:08 Inactive
ChargrilledChook
ChargrilledChook approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@ChargrilledChook ChargrilledChook left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✨

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3852 June 30, 2023 10:21 Inactive
@KevinMulhern KevinMulhern merged commit 552de31 into main Jun 30, 2023
@KevinMulhern KevinMulhern deleted the feature/hotwire-add-project branch June 30, 2023 10:44
@KevinMulhern
Copy link
Member Author

Relates to #3908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChargrilledChook ChargrilledChook ChargrilledChook approved these changes

Assignees

@KevinMulhern KevinMulhern

Labels
Type: Enhancement Involves a new feature or enhancement request
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinMulhern @ChargrilledChook