Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Display project submissions list using Hotwire #3839

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Chore: Display project submissions list using Hotwire #3839

merged 1 commit into from
Jun 7, 2023

Conversation

KevinMulhern
Copy link
Member

Because

  • We can simplify and make our project submissions feature more robust by using Hotwire.

This commit:

  • Add v2_project submissions feature flag, controllers and routes so we can move things over gradually.
  • Add project submission item component to replicate the submission item component we have in react.
  • Lazily load the submission list with Hotwire - displays a loading spinner until the list response is rendered.

@KevinMulhern
Copy link
Member Author

My plan with this is to move things over gradually feature by feature to keep the PR's small and reduce risk.

@KevinMulhern KevinMulhern self-assigned this Jun 7, 2023
@KevinMulhern KevinMulhern added the Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. label Jun 7, 2023
@KevinMulhern KevinMulhern changed the title Chore: Display project Submissions list using Hotwire Chore: Display project submissions list using Hotwire Jun 7, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3839 June 7, 2023 10:23 Inactive
@ChargrilledChook ChargrilledChook self-requested a review June 7, 2023 12:30
@KevinMulhern
Chore: Display project Submissions list using Hotwire
9b6cdb7 
Because
* We can simplify and make our project submissions feature more robust by using Hotwire.

This commit:
* Add v2_project submissions feature flag, controllers and routes so we can move things over gradually.
* Add project submission item component to replicate the submission item component we have in react.
* Lazily load the submission list with Hotwire - displays a loading spinner until the list response is rendered.
@KevinMulhern KevinMulhern force-pushed the chore/move-submission-list-to-hotwire branch from 3032bfa to 9b6cdb7 Compare June 7, 2023 18:11
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3839 June 7, 2023 18:11 Inactive
@KevinMulhern KevinMulhern merged commit 20fa1ac into main Jun 7, 2023
@KevinMulhern KevinMulhern deleted the chore/move-submission-list-to-hotwire branch June 7, 2023 21:03
@KevinMulhern
Copy link
Member Author

Relates to #3908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CouchofTomato CouchofTomato CouchofTomato approved these changes

@ChargrilledChook ChargrilledChook Awaiting requested review from ChargrilledChook

Assignees

@KevinMulhern KevinMulhern

Labels
Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinMulhern @CouchofTomato