Skip to content

Commit

Permalink
Fix: Inconsistent link hover behaviour (#3972)
Browse files Browse the repository at this point in the history
Because:
* We were only removing the underline on hover for external links. This
resulted in some links sections having links with different hover
behaviour.
* I think this rule was added so the links in headings wouldn't display
an underline on hover - but it doesn't seem to be needed anymore.



https://github.com/TheOdinProject/theodinproject/assets/7963776/4b43c711-4674-4679-ba5d-2f34f8868451



This commit:
* Removes the http matcher regex from the lesson content link selector.
  • Loading branch information
KevinMulhern committed Jul 15, 2023
1 parent 97c3793 commit 097edfc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/javascript/stylesheets/lesson-content.css
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
@apply mt-0;
}

.lesson-content a[href^="http"] {
.lesson-content a {
@apply hover:no-underline;
}

Expand Down

0 comments on commit 097edfc

Please sign in to comment.