Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/2] Foundations: Update objects lesson with a clearer image #28727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathdebate09
Copy link
Contributor

@mathdebate09 mathdebate09 commented Sep 1, 2024

Because

Update the objects lesson example on array functions, which explained using the steps for making a sandwich

This PR

  • Add a clearer image

Issue

Related to #28696

Additional Information

Resolution: 1780 x 1200
Figma: https://www.figma.com/design/1ciJyJEooYzsDJL8YVYIAy/TOP-objects?m=auto&t=bLlucYPnGfPrRHd6-1

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Sep 1, 2024
Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

One question, are the images you used public domain or otherwise compatible with our license?

@mathdebate09
Copy link
Contributor Author

Ah, this might be an issue, I'll recheck them/search for free for commercial use ones and update you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants