Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mega_time added to config #191

Merged
merged 4 commits into from
Aug 19, 2020
Merged

mega_time added to config #191

merged 4 commits into from
Aug 19, 2020

Conversation

angarb
Copy link
Collaborator

@angarb angarb commented Aug 12, 2020

Here is the PR to add the new mega_time parameter to address both #173 and #137

@sk-sahu sk-sahu self-requested a review August 12, 2020 15:01
@sk-sahu
Copy link
Contributor

sk-sahu commented Aug 12, 2020

@angarb This looks good 🚀 Once you squash and merge, please close the mentioned issues or if more follow up needed mention in the issue comment.

@sk-sahu
Copy link
Contributor

sk-sahu commented Aug 12, 2020

Also @angarb if you can document this new param - mega_time That will be helpful for future users.

Comment on lines +12 to +14
params {
mega_time = 20.h
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document on this new param - Here is how to do

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

@angarb angarb changed the title max_time added to config mega_time added to config Aug 19, 2020
Copy link
Contributor

@sk-sahu sk-sahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@angarb angarb closed this Aug 19, 2020
@angarb angarb reopened this Aug 19, 2020
@angarb angarb merged commit 940ce2c into master Aug 19, 2020
@angarb angarb deleted the new_config branch August 19, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a 'big job' option in STAR Job killed by SLURM during star process due to time error with large BAMs
2 participants