Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed list of points to be space-separated #93

Merged

Conversation

erickmartins
Copy link
Collaborator

Description

This is a two-line fix to align with the OME data model and hopefully fix #90 (though I couldn't reproduce it).

Checklist

This fix is purely internal to an ezomero function, so no changed function signature at all. Tests passing, flake8, etc etc

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.

@erickmartins erickmartins merged commit dfadca9 into TheJacksonLaboratory:main Dec 22, 2023
1 check passed
@erickmartins erickmartins deleted the fix-point-separator branch December 22, 2023 20:15
erickmartins added a commit that referenced this pull request Jan 23, 2024
* Automated updating coverage badge

* bump to 5.13.1, fix for SSL (#76)

* Automated updating coverage badge

* `put_description` implemented (#78)

* docstring and function signature

* function is there and on init - on to tests

* tests passing

* flake8 pass

* updated upload to test pypi to use python 3.8

* adds `get_comment_annotation_ids`, `get_comment_annotation`, `post_comment_annotation` (#79)

* added `get_comment_ids`

* added `get_comment`

* added `post_comment_annotation`

* added `test_get_comment_annotation_and_ids`

* added `test_post_get_comment_annotation`, all passing

* Automated updating coverage badge

* fixed typo that set fill color instead of stroke color when stroke not specified (#82)

* Automated updating coverage badge

* Doi and numpy (#85)

* added publication badge

* fixed badge

* future-proofing against numpy 2.0.0

* added CITATION.cff

* Automated updating coverage badge

* fixing leftover datasets when `post_dataset` fails to link it to a project (#87)

* deleting created dataset if it cannot be linked to project

* removed naked except and bad type tests

* flake8

* removing print

* Automated updating coverage badge

* updating omero-py version (#91)

* Automated updating coverage badge

* changed list of points to be space-separated (#93)

* changed list of points to be space-separated

* fixing EOL issue

* Automated updating coverage badge

* `post_file_annotation` can now create orphaned `FileAnnotation`s (#92)

* updating omero-py version

* post_file_annotation can do orphans

* Automated updating coverage badge

* updated omero-py version (#94)

* updated omero-py version

* fix typo in docstring because why not

* using glencoe's zeroc-ice

* it's installing too fast (!!!) now

* Automated updating coverage badge

* updated docs

---------

Co-authored-by: Erick Ratamero <[email protected]>
Co-authored-by: Kiya Govek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] post_roi() for polygon and polyline not working
1 participant