Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespace'd @items property #108

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

TheGiddyLimit
Copy link
Owner

The base property confuses MidiQOL, and so will be removed in next Plutonium release. An alternative has been added under our namespace.

The base property confuses MidiQOL, and so will be removed in next
Plutonium release. An alternative has been added under our namespace.
Copy link
Collaborator

@Spappz Spappz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wondering about the benefit of PAA itself managing automations like this when CPR does it already (as opposed to simple "make sure the targets field is correct because WotC can't write consistent statblocks"). When we first started this, I was hopeful that it wouldn't be too difficult to build up community support (or at least just me exporting a bunch as I went along) but clearly that was naive 🤣

@TheGiddyLimit
Copy link
Owner Author

yeah might be best to just remove them but
that also requires reviewing each thing vs e.g. CPR, so it's time either way

@Spappz
Copy link
Collaborator

Spappz commented Mar 28, 2024

Could just raise the priority of extensions to the top 😏

@TheGiddyLimit TheGiddyLimit merged commit 49855dc into master Apr 3, 2024
1 check passed
@TheGiddyLimit TheGiddyLimit deleted the bugfix/namespace-items branch April 3, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants