-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display an error message if upload fails #41
Open
tacman
wants to merge
1
commit into
TheFox:master
Choose a base branch
from
tacman:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no error message if the endpoint returned a valid SimpleXML object but it contained an error message. This displays one now (for example, a permissions error).
This is a little bit too much logging. There is already a logging call. See Line 425 in your file: $this->getLogger()->info(sprintf('[file] status: %s - ID %s', $logLine, $photoId)); There is already a Therefore I have to reject this PR. But thanks for your will to improve Flickr CLI. |
Could you add the error message to the log? The problem is that if the
REST returns an error, there's no way to know what the error is, it simply
says FAIL.
…On Mon, Feb 19, 2018 at 9:31 AM, Christian Mayer ***@***.***> wrote:
This is a little bit too much logging. There is already a logging call.
See Line 425
<https://github.com/tacman/flickr-cli/blob/9f1102c4ca843b79187691ac3ee96eed637e9d0f/src/TheFox/FlickrCli/Command/UploadCommand.php#L324>
in your file:
$this->getLogger()->info(sprintf('[file] status: %s - ID %s', $logLine, $photoId));
There is already a if ($successful) check. I want to keep it simple.
Therefore I have to reject this PR. But thanks for your will to improve
Flickr CLI.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAl0QdEvee0VjDwqE6K3jLs2d8-Bj34aks5tWYXagaJpZM4SKCed>
.
|
Also, it should be logger->error, not logger->info, since it is definitely
an error and should be tagged as such (that is, you don't need to turn on
verbose to see it).
…On Mon, Feb 19, 2018 at 9:41 AM, Tac Tacelosky ***@***.***> wrote:
Could you add the error message to the log? The problem is that if the
REST returns an error, there's no way to know what the error is, it simply
says FAIL.
On Mon, Feb 19, 2018 at 9:31 AM, Christian Mayer ***@***.***
> wrote:
> This is a little bit too much logging. There is already a logging call.
> See Line 425
> <https://github.com/tacman/flickr-cli/blob/9f1102c4ca843b79187691ac3ee96eed637e9d0f/src/TheFox/FlickrCli/Command/UploadCommand.php#L324>
> in your file:
>
> $this->getLogger()->info(sprintf('[file] status: %s - ID %s', $logLine, $photoId));
>
> There is already a if ($successful) check. I want to keep it simple.
>
> Therefore I have to reject this PR. But thanks for your will to improve
> Flickr CLI.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#41 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAl0QdEvee0VjDwqE6K3jLs2d8-Bj34aks5tWYXagaJpZM4SKCed>
> .
>
|
Good point. I'll to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no error message if the endpoint returned a valid SimpleXML object but it contained an error message. This displays one now (for example, a permissions error).