Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge EE (Blood Trails) #28

Merged
merged 33 commits into from
Nov 11, 2024
Merged

Merge EE (Blood Trails) #28

merged 33 commits into from
Nov 11, 2024

Conversation

sleepyyapril
Copy link
Contributor

@sleepyyapril sleepyyapril commented Nov 9, 2024

Description

I merge with EE, we get blood trails. Yippee.

VMSolidus and others added 16 commits November 8, 2024 10:17
# Description

Familiars were hilariously overpowered.

# Changelog

:cl:
- fix: Familiars can now be Dispelled.
- tweak: Nerfed Remilia to have 30 HP.
- tweak: Nerfed Base Familiar to have 50 HP.
# Description

Port of Lost-Paradise-Project/Lost-Paradise#288
from Lost Paradise. This feature makes it so that the language you are
speaking is shown in chat, preventing any confusion for players about
what it is being spoken.

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/25fa3e17-30bb-4ae7-8fbe-2114839c498d)

</p>
</details>

# Changelog

:cl:
- add: Languages are now shown in chat alongside character names.

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: Remuchi <[email protected]>
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

minor on the maps rad and gax

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->



---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>



</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: minor fixes on the maps Rad and Gax, fix te uranium crarte to
filled

---------

Co-authored-by: VMSolidus <[email protected]>
# Description

Traits Version 2 implements a much needed overhaul of the Trait System,
changing it so that it no longer uses hardcoded nullable lists of
various entries required for the trait functions, and instead accepts a
*single* Modular List of Functions, and then iterates through the list
like a set of instructions on how to modify the character. This PR also
features a few new Functions, such as AddImplant.

Anyway, rather than hardcoding a new codepath for every new function,
new functions can simply be made separate from the codepath entirely,
and will only be called if they are included in the trait itself.

# TODO

- [x] Remove ALL pre-existing trait functions and move them over to the
new system.
- [x] Evaluate which System Dependencies are essential for a majority of
functions, and make sure that TraitSystem is caching them on behalf of
the functions that need them for performance reasons. This system has a
fairly high startup cost for frametime to begin with.
- [x] Update all pre-existing traits such that they use the new System.

# BREAKING CHANGES

ALL DOWNSTREAM TRAITS WILL NEED TO BE MODIFIED TO USE THE NEW SYSTEM. 

# Changelog

:cl:
- add: Traits can now add Implants directly.

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: gluesniffler <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
# Description

Me, Death, and many more people have agreed that Shadowkin as they
currently are do not meet our quality expectations for a playable
species. This PR temporarily disables them, pending further updates to
address severe balance, lack of system interactions, and playability
issues. I've spoken at length about my many issues with the Species, and
have long since regretted merging them in their current state.

I'm calling in my "self-merge by proxy token" on this.

# Changelog

:cl:
- remove: Shadowkin have been temporarily disabled pending significant
reworks and balance updates.
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Fixes power flickers.
# Description

This ports WWhiteDreamProject/wwdpublic#110 from
WWDP. This features significantly increases the interactions players
have with Blood puddles, but introducing a mechanic whereby if players
walk through puddles of blood, or attempt to drag a bloody corpse, they
leave behind bloodstains as evidence of their presence or actions. You
can avoid leaving marks from dragging corpses by using a rollerbed, and
you can avoid leaving bloody footprints by avoiding walking in blood.

This creates a great deal of emergent gameplay for all roles, but
especially Traitors, Security(DETECTIVES!) and Janitors(Who now have to
clean up bloody footprints!). Naturally, you can use syndicate soap to
clean up any evidence of your crimes.

# TODO

- [x] Code Cleanup and Namespaces

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/a60b3af7-6881-4338-836f-32bf45df9f90)

</p>
</details>

# Changelog

:cl:
- add: Added Bloodstains, Body Dragging Marks, and Bloody Footprints to
the game. Characters that walk through puddles of blood will now leave
behind bloody footprints. Dragging a corpse leaves a trail of blood
wherever the corpse was moved.

---------

Co-authored-by: Spatison <[email protected]>
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

No merge this time, quite literally just basic changes. Should solve all
issues, as this is how I did it on my fork.
Changes carp rifts and nuke arming to use readable locations.

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![Beacons
example](https://github.com/user-attachments/assets/9272b442-9b11-41b3-a0d1-d7954a645b1d)

</p>
</details>

---

# Changelog
nah
Copy link
Contributor

github-actions bot commented Nov 9, 2024

RSI Diff Bot; head commit c43b591 merging into dc4225a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Effects/footprints.rsi

State Old New Status
dragging-1 Added
dragging-2 Added
dragging-3 Added
dragging-4 Added
dragging-5 Added
dragging-test Added
footprint-left-bare-diona Added
footprint-left-bare-dwarf Added
footprint-left-bare-human Added
footprint-left-bare-lizard Added
footprint-left-bare-slime Added
footprint-left-bare-spider Added
footprint-right-bare-diona Added
footprint-right-bare-dwarf Added
footprint-right-bare-human Added
footprint-right-bare-lizard Added
footprint-right-bare-slime Added
footprint-right-bare-spider Added
footprint-shoes Added
footprint-suit Added

Edit: diff updated after c43b591

sleepyyapril and others added 7 commits November 9, 2024 12:55
# Description

Cherry-picks
space-wizards/space-station-14#28375 to fix an
issue with BUIs closing themselves.

Co-authored-by: metalgearsloth <[email protected]>
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Fixes the call shuttle button.
# Description

Maintainer suggested changes broke the AddTrait and ReplaceTrait
functionality of the Version 2 Trait Functions. This restores their
functionality.

# Changelog

:cl:
- fix: Fixed AddTrait and ReplaceTrait functions giving players an
unmodified, completely default component.
This is an automated Pull Request. This PR updates the GitHub
contributors in the credits section.

Co-authored-by: SimpleStation Changelogs <[email protected]>
sleepyyapril and others added 8 commits November 11, 2024 01:19
# Description

Added missing environment variable for nix-shell. I don't like everytime
write `export DOTNET_ROOT="/path/to/folder"`, so it should be done by
post script in `shell.nix`
@sleepyyapril sleepyyapril merged commit 3dd8de3 into master Nov 11, 2024
14 checks passed
@sleepyyapril sleepyyapril deleted the blood-trails-please branch November 11, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants