Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump websocket-extensions from 0.1.3 to 0.1.4 #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jun 8, 2020

Bumps websocket-extensions from 0.1.3 to 0.1.4.

Changelog

Sourced from websocket-extensions's changelog.

0.1.4 / 2020-06-02

  • Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)
  • Change license from MIT to Apache 2.0
Commits
  • 8efd0cd Bump version to 0.1.4
  • 3dad4ad Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser
  • 4a76c75 Add Node versions 13 and 14 on Travis
  • 44a677a Formatting change: {...} should have spaces inside the braces
  • f6c50ab Let npm reformat package.json
  • 2d211f3 Change markdown formatting of docs.
  • 0b62083 Update Travis target versions.
  • 729a465 Switch license to Apache 2.0.
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 8, 2020
@cxgslegend
Copy link
Contributor

So I tested this change out in my fork, and everything seemed to work fine (fork, fork website). So I wouldn't be opposed to merging the PR. However, I am not so sure what the policy should be for changing the package-lock.json file. I would assume the change would eventually be added through packages changing their dependencies in the package.json file.

Regardless, it shouldn't hurt anything if you want to merge it. I'll just let @LovelySanta decide.

@LovelySanta
Copy link
Collaborator

LovelySanta commented Jun 9, 2020

package-lock.json is created while running npm install, right? Then the question is, do we need that file on github itself? The bot is only creating PRs to bump version numbers, to inform about security vulnerabilities... Does it add any benefit from updating? Or any way to make sure it auto installs latest updates for sub-dependencies?

@cxgslegend
Copy link
Contributor

cxgslegend commented Jun 10, 2020

My understanding of the package-lock.json file, builds a dependency graph from your package.json file. This has a side effect of locking the dependency versions in place to what was pulled in the last time you run npm install.

So for example, say one of the dependencies in our package.json file had a dependency on websockets-extensions ^0.1.3*. This would automatically use 0.1.4, when a developer ran npm install. So the package-lock.json file locks the versions in place so that every developer has the same dependencies.

@LovelySanta
Copy link
Collaborator

Ok, I'll test this on my system when I have time (probably in 2 weeks or so)

@cxgslegend
Copy link
Contributor

Yeah, it should be exact same on your system. The package-lock.json file will only regenerate if you delete it and run npm install. But if you just run npm install without deleting it, it will only regenerate the file if you changed something in the package.json file.

Just saying that, because my last message was a mess to re-read. I should probably learn how to proof read. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants