Use mergeme
to merge CLI config
#452
Open
+193
−366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
mergeme
is a little crate that I wrote1 that makes it easy to merge structures together. For example:This PR greatly simplifies the API surface of
CliConfig
by offloading the merging logic tomergeme
's derive macro.Major Changes
CliConfig::for_package()
andCliConfig::merged_from_metadata()
have been combined into a singleCliConfig::from_metadata()
function that takes a&serde_json::Value
for the[package.metadata]
table2.That should be the only visible change, and that's only API-related. The CLI should behave the same, but please be sure to test on actual projects with nested configuration to ensure it works!
Footnotes
You can tell because there are more docs and comments than actual code >:D ↩
Not
[package.metadata.bevy_cli]
, but just[package.metadata]
. This is why the unit tests were changed in the way they were. ↩