Merge pull request #8 from TheBestTvarynka/refactor/ci

Update CI config and fix clippy warnings
TheBestTvarynka · Mar 17, 2024 · 781a090 · 781a090
2 parents e807dd9 + ff5b2fd
commit 781a090
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/check-pr.yml b/.github/workflows/check-pr.yml
@@ -22,4 +22,4 @@ jobs:
       run: 'cargo +nightly fmt --all -- --check'
 
     - name: 'Clippy'
-      run: 'cargo clippy -- -D warnings'
+      run: 'cargo clippy --all-targets --all-features -- -D warnings'
diff --git a/.github/workflows/github-actions.yml b/.github/workflows/github-actions.yml
@@ -25,7 +25,7 @@ jobs:
       run: 'cargo +nightly fmt --all -- --check'
 
     - name: 'Clippy'
-      run: 'cargo clippy --all-features -- -D warnings'
+      run: 'cargo clippy --all-features --all-targets -- -D warnings'
 
   check-examples-matrix:
     strategy:
@@ -47,7 +47,7 @@ jobs:
       run: 'cd examples/${{ matrix.example }} && cargo +nightly fmt --all -- --check'
 
     - name: 'Clippy'
-      run: 'cd examples/${{ matrix.example }} && cargo clippy -- -D warnings'
+      run: 'cd examples/${{ matrix.example }} && cargo clippy --all-targets --all-features -- -D warnings'
 
   deploy-documentation:
     name: Deploy documentation

diff --git a/examples/basic/src/main.rs b/examples/basic/src/main.rs
@@ -97,7 +97,7 @@ fn inner(props: &InnerProps) -> Html {
 
 #[function_component(App)]
 pub fn app() -> Html {
-    let component_creator = NotificationFactory::default();
+    let component_creator = NotificationFactory;
     let position = use_state(|| NotificationsPosition::TopRight);
     let position_setter = position.setter();
 

diff --git a/examples/custom/src/main.rs b/examples/custom/src/main.rs
@@ -34,7 +34,7 @@ fn inner() -> Html {
 
 #[function_component(App)]
 pub fn app() -> Html {
-    let component_creator = CustomNotificationFactory::default();
+    let component_creator = CustomNotificationFactory;
 
     html! {
         <div>

diff --git a/examples/terminal/src/main.rs b/examples/terminal/src/main.rs
@@ -45,7 +45,7 @@ fn inner() -> Html {
 
 #[function_component(App)]
 pub fn app() -> Html {
-    let component_creator = TerminalNotificationFactory::default();
+    let component_creator = TerminalNotificationFactory;
     let position = NotificationsPosition::Custom("terminal-notifications".into());
 
     html! {

diff --git a/examples/terminal/src/notification/mod.rs b/examples/terminal/src/notification/mod.rs
@@ -45,7 +45,7 @@ impl Notifiable for TerminalNotification {
     }
 
     fn apply_tick(&mut self, time: Duration) {
-        self.lifetime = self.lifetime.checked_sub(time).unwrap_or(Duration::default());
+        self.lifetime = self.lifetime.checked_sub(time).unwrap_or_default();
     }
 
     fn is_alive(&self) -> bool {

diff --git a/src/notification/mod.rs b/src/notification/mod.rs
@@ -222,7 +222,7 @@ impl Notifiable for Notification {
     }
 
     fn apply_tick(&mut self, time: Duration) {
-        self.lifetime = self.lifetime.checked_sub(time).unwrap_or(Duration::default());
+        self.lifetime = self.lifetime.checked_sub(time).unwrap_or_default();
     }
 
     fn is_alive(&self) -> bool {