-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable reftex-parse-all
#13
base: master
Are you sure you want to change the base?
Conversation
Thank you for that improvement. Side note: I personally think a hook would have been better. You could have offered I ask the OP to test your changes. (I do not have his LaTeX sources.) |
|
No problem and thanks for the clarification. Does #14 reflect the idea you had in mind? In case I misunderstood something, it would be good if you could add a code suggestion so I can visualize this better.
I see your point. The only thing I am hesitant about in regards to the hook is the (perhaps unnecessary) freedom provided to the user. AFAIK there are basically two ways to go about parsing the labels; either parse the single file or parse the multi-file document. Leaving this hook empty would render the parser useless. I also don't see any practical optimization that a user can make without going deep into Do you know what I mean, or do you have another perspective?
Perfect, thank you. |
Hello everybody, I just wanted to tune in here on the problem. I implemented the change Tobias asked me for and tried it on my system. Sadly, the problem still persists. As soon as I enter a UPDATE: |
4f0d680
to
1929da2
Compare
Addresses #11
1929da2
to
481f8f7
Compare
Hi @Captn-LootALot. Thanks for reporting back regarding the performance. One thing to clarify though:
While setting
Overall, I am on board to merge this PR as it constitutes a trivial but effective change. As mentioned in #13 (comment), I am less comfortable with having a customizable hook unless @TobiasZawada or @TheBB have strong opinions in favour of the customizable hook? PS: I created a new PR #14 for the customizable hook so we keep the diffs in separate branches |
Hello @atreyasha thank you for the heads-up. Whenever I need to scan all documents again I usually call |
I think there is a misunderstanding here.
This PR will change how MWE
Environment (environment.tar.gz)
|
Thank you for coming back to this. I tested your MWE and you are absolutely right. I do understand now that what I earlier wrote cannot be possible. I will take a look at my earlier setup and see what I did wrong. Again, thank you! |
Thanks @atreyasha, this is a nice fix. I often work with multi-file latex projects, and this PR improves performance drastically. I just call |
Overview
This PR addresses #11 by adding an option to disable the call to
reftex-parse-all
, which could be the cause of the performance sink reported.Tasks before merge