Skip to content

Improve Project Euler problem 070 solution 1 #5166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2021
Merged

Improve Project Euler problem 070 solution 1 #5166

merged 2 commits into from
Oct 30, 2021

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Improve Project Euler problem 070 solution 1:

  • Change has_same_digits doctest (replace has_same_digits(123, 12) with similar has_same_digits(123, 23) which failed in current implementation)

  • Improve has_same_digits function (it passes changed test)

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 9, 2021
@MaximSmolskiy
Copy link
Member Author

@poyea @l3str4nge please review

l3str4nge
l3str4nge reviewed Oct 30, 2021
View reviewed changes
project_euler/problem_070/sol1.py
>>> has_same_digits(123456789, 987654321)
True

>>> has_same_digits(123, 12)
>>> has_same_digits(123, 23)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changed?

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2021
@l3str4nge l3str4nge merged commit e7565f8 into TheAlgorithms:master Oct 30, 2021
@MaximSmolskiy MaximSmolskiy deleted the improve-project-euler-problem-070-solution-1 branch October 30, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximSmolskiy @l3str4nge