added ridge_regression.py #12553
added ridge_regression.py #12553
Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
machine_learning/ridge_regression.py
Outdated
|
|
||
| # Ridge Regression function | ||
| # reference : https://en.wikipedia.org/wiki/Ridge_regression | ||
| def ridge_cost_function(x: np.ndarray, y: np.ndarray, theta: np.ndarray, alpha: float) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function ridge_cost_function
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
machine_learning/ridge_regression.py
Outdated
| cost += (alpha / 2) * np.sum(theta[1:] ** 2) | ||
| return cost | ||
|
|
||
| def ridge_gradient_descent(x: np.ndarray, y: np.ndarray, theta: np.ndarray, alpha: float, learning_rate: float, max_iterations: int) -> np.ndarray: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function ridge_gradient_descent
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
machine_learning/ridge_regression.py
Outdated
| print(f"Optimized theta: {optimized_theta}") | ||
|
|
||
| # Prediction | ||
| def predict(X, theta): |
There was a problem hiding this comment.
Please provide return type hint for the function: predict. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function predict
Please provide descriptive name for the parameter: X
Please provide type hint for the parameter: X
Please provide type hint for the parameter: theta
algorithms-keeper
bot
removed
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
machine_learning/ridge_regression.py
Outdated
| max_iterations = 1000 | ||
|
|
||
| <<<<<<< HEAD | ||
| optimized_theta = ridge_gradient_descent(x, y, theta_initial, alpha, learning_rate, max_iterations) |
There was a problem hiding this comment.
An error occurred while parsing the file: machine_learning/ridge_regression.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
reports = lint_file(
^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 99:3.
parser error: error at 98:2: expected one of (, *, +, -, ..., AWAIT, EOF, False, NAME, NUMBER, None, True, [, break, continue, elif, else, lambda, match, not, pass, ~
optimized_theta = ridge_gradient_descent(x, y, theta_initial, alpha, learning_rate, max_iterations)
^
algorithms-keeper
bot
added
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
machine_learning/ridge_regression.py
Outdated
|
|
||
| # Ridge Regression function | ||
| # reference : https://en.wikipedia.org/wiki/Ridge_regression | ||
| def ridge_cost_function(x: np.ndarray, y: np.ndarray, theta: np.ndarray, alpha: float) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function ridge_cost_function
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
machine_learning/ridge_regression.py
Outdated
|
|
||
| return cost | ||
|
|
||
| def ridge_gradient_descent(x: np.ndarray, y: np.ndarray, theta: np.ndarray, alpha: float, learning_rate: float, max_iterations: int) -> np.ndarray: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function ridge_gradient_descent
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
| print(f"Optimized theta: {optimized_theta}") | ||
|
|
||
| # Prediction | ||
| def predict(x, theta): |
There was a problem hiding this comment.
Please provide return type hint for the function: predict. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function predict
Please provide descriptive name for the parameter: x
Please provide type hint for the parameter: x
Please provide type hint for the parameter: theta
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
machine_learning/ridge_regression.py
Outdated
|
|
||
| # Ridge Regression function | ||
| # reference : https://en.wikipedia.org/wiki/Ridge_regression | ||
| def ridge_cost_function(x: np.ndarray, y: np.ndarray, theta: np.ndarray, alpha: float) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function ridge_cost_function
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
machine_learning/ridge_regression.py
Outdated
|
|
||
| return cost | ||
|
|
||
| def ridge_gradient_descent(x: np.ndarray, y: np.ndarray, theta: np.ndarray, alpha: float, learning_rate: float, max_iterations: int) -> np.ndarray: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function ridge_gradient_descent
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
| print(f"Optimized theta: {optimized_theta}") | ||
|
|
||
| # Prediction | ||
| def predict(x, theta): |
There was a problem hiding this comment.
Please provide return type hint for the function: predict. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function predict
Please provide descriptive name for the parameter: x
Please provide type hint for the parameter: x
Please provide type hint for the parameter: theta
for more information, see https://pre-commit.ci
…8/Python into added-ridge-regression
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
machine_learning/ridge_regression.py
Outdated
|
|
||
| # Ridge Regression function | ||
| # reference : https://en.wikipedia.org/wiki/Ridge_regression | ||
| def ridge_cost_function(x: np.ndarray, y: np.ndarray, theta: np.ndarray, alpha: float) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function ridge_cost_function
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
machine_learning/ridge_regression.py
Outdated
|
|
||
| return cost | ||
|
|
||
| def ridge_gradient_descent(x: np.ndarray, y: np.ndarray, theta: np.ndarray, alpha: float, learning_rate: float, max_iterations: int) -> np.ndarray: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function ridge_gradient_descent
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
| print(f"Optimized theta: {optimized_theta}") | ||
|
|
||
| # Prediction | ||
| def predict(x, theta): |
There was a problem hiding this comment.
Please provide return type hint for the function: predict. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file machine_learning/ridge_regression.py, please provide doctest for the function predict
Please provide descriptive name for the parameter: x
Please provide type hint for the parameter: x
Please provide type hint for the parameter: theta
for more information, see https://pre-commit.ci
Describe your change:
Checklist: