feat: add sentinel search algorithm #1683
Open
+89
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasanalkaf3
requested review from
raklaptudirm and
appgurueu
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 84.65% 84.70% +0.05%
==========================================
Files 378 379 +1
Lines 19744 19770 +26
Branches 2951 2959 +8
==========================================
+ Hits 16715 16747 +32
+ Misses 3029 3023 -6 ☔ View full report in Codecov by Sentry. |
appgurueu
reviewed
Oct 2, 2024
Search/QuickSelectSearch.js
Outdated
| @@ -18,16 +18,15 @@ export function quickSelectSearch(array, k) { | |||
|
|
|||
| let from = 0 | |||
| let to = array.length - 1 | |||
|
|
|||
There was a problem hiding this comment.
Please keep unrelated changes out of this PR
appgurueu
reviewed
Oct 2, 2024
Search/SentinelSearch.js
Outdated
| @@ -0,0 +1,41 @@ | |||
| /** | |||
| * @function sentinelSearch | |||
There was a problem hiding this comment.
Suggested change
| * @function sentinelSearch |
appgurueu
reviewed
Oct 2, 2024
Search/SentinelSearch.js
Outdated
| * @example sentinelSearch([1,2,3], 2) => 1 | ||
| * @example sentinelSearch([4,5,6], 2) => null | ||
| * @complexity_analysis | ||
| * Time Complexity : |
There was a problem hiding this comment.
I think just O(n) or omitting it altogether would suffice here. It's pretty trivial to see.
appgurueu
reviewed
Oct 3, 2024
Search/QuickSelectSearch.js
Outdated
| while (from < to) { | ||
| let [left, right] = [from, to] | ||
| let left = from |
There was a problem hiding this comment.
Please keep unrelated changes out of this PR.
appgurueu
requested changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.