Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Temp Variable #1529

Closed
wants to merge 1 commit into from
Closed

Conversation

imrahulkb
Copy link
Contributor

Removed temp variable and implemented the swap functionality using the bitwise xor technique.

Open in Gitpod know more

Describe your change:

Modified the Swap Functionality by replacing temp variable with the Bitwise XOR Technique.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Removed temp variable and implemented the swap functionality using the bitwise xor technique.
@appgurueu
Copy link
Collaborator

Sorry, but this does not preserve behavior; the array need not consist out of 32-bit integers.

It would be an option to convert all swaps in this repo to [a, b] = [b, a] for consistency (though the temp var is fine as well, imo).

@appgurueu appgurueu closed this Oct 14, 2023
@imrahulkb imrahulkb deleted the patch-2 branch October 14, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants