Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added find subsets algorithm using bitmanipulation #1514

Merged
merged 6 commits into from
Oct 26, 2023
Merged

feat: added find subsets algorithm using bitmanipulation #1514

merged 6 commits into from
Oct 26, 2023

Conversation

Nikunj-bisht
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also have an error case if the array is too large (more than 32 elements, since you only have 32 bits). This error case should be tested.

Otherwise fine!

Bit-Manipulation/GenerateSubSets.js Show resolved Hide resolved
Bit-Manipulation/GenerateSubSets.js Outdated Show resolved Hide resolved
@Nikunj-bisht
Copy link
Contributor Author

@appgurueu made the required changes

@Nikunj-bisht
Copy link
Contributor Author

@appgurueu done with all the changes

@Nikunj-bisht
Copy link
Contributor Author

@appgurueu @raklaptudirm can we merge this pr?

@raklaptudirm raklaptudirm merged commit d671327 into TheAlgorithms:master Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

@appgurueu appgurueu appgurueu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nikunj-bisht @appgurueu @raklaptudirm