Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add binary to BCD conversion algorithm #1509

Closed
wants to merge 2 commits into from
Closed

feat: add binary to BCD conversion algorithm #1509

wants to merge 2 commits into from

Conversation

piyushk77
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectively the same as #1416 but for numbers - a simple encoding via substitution.

piyushk77
piyushk77 commented Oct 11, 2023
View reviewed changes
Copy link
Contributor Author

@piyushk77 piyushk77 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appgurueu Yeah, you are right. Actually I saw many simple but useful algorithms related to such conversions in the repo. Therefore decided to add one for BCD conversion.

@piyushk77
Copy link
Contributor Author

Should I close this PR?

@piyushk77 piyushk77 closed this Oct 12, 2023
@piyushk77 piyushk77 deleted the patch-4 branch October 12, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piyushk77 @appgurueu