Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:longest common prefix in a string #1501

Closed
wants to merge 5 commits into from
Closed

feat:longest common prefix in a string #1501

wants to merge 5 commits into from

Conversation

AmbrishRamachandiran
Copy link

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Signed-off-by: AmbrishRamachandiran <[email protected]>
Signed-off-by: AmbrishRamachandiran <[email protected]>
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise fine except for the repeated string concatenation; this is usually optimized out in practice, but here it's def. just cleaner to keep track of max. index up to which all strings share a common prefix, and then use that to substring shortestString.

(Algorithm-wise still pretty trivial, though.)

Signed-off-by: AmbrishRamachandiran <[email protected]>
Signed-off-by: AmbrishRamachandiran <[email protected]>
Signed-off-by: AmbrishRamachandiran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants