fix: remove memory leak from circular_queue_using_linked_list.cpp (#…

…2731)
TheAlgorithms · Sep 13, 2024 · 8df7a88 · 8df7a88
1 parent 920b6d4
commit 8df7a88
Showing 1 changed file with 36 additions and 20 deletions.
diff --git a/data_structures/circular_queue_using_linked_list.cpp b/data_structures/circular_queue_using_linked_list.cpp
@@ -5,49 +5,65 @@ struct node {
     struct node* next;
 };
 class Queue {
-    node* front=nullptr;
-    node* rear=nullptr;
+    node* front = nullptr;
+    node* rear = nullptr;
 
-public:
-    Queue() = default; 
+    Queue(const Queue&) = delete;
+    Queue& operator=(const Queue&) = delete;
+
+ public:
+    Queue() = default;
+    ~Queue() {
+        while (front) {
+            dequeue();
+        }
+    }
+
+ private:
     void createNode(int val) {
         auto* nn = new node;
         nn->data = val;
         nn->next = nullptr;
         front = nn;
         rear = nn;
     }
+
+ public:
     void enqueue(int val) {
         if (front == nullptr || rear == nullptr) {
             createNode(val);
-        }
-        else {
-            node* nn;
-            nn = new node;
+        } else {
+            node* nn = new node;
             nn->data = val;
             rear->next = nn;
             nn->next = front;
             rear = nn;
         }
     }
     void dequeue() {
-        node* n;
-        n = front;
-        if (n) {
+        if (front == nullptr) {
+            return;
+        }
+        const node* const n = front;
+        if (front == rear) {
+            front = nullptr;
+            rear = nullptr;
+        } else {
             front = front->next;
-            delete n;
+            rear->next = front;
         }
+        delete n;
     }
     void traverse() {
-        node* ptr;
-        ptr = front;
-        if (ptr) {
-            do {
-                std::cout << ptr->data << " ";
-                ptr = ptr->next;
-            } while (ptr != rear->next);
-            std::cout << front->data << std::endl;
+        if (front == nullptr) {
+            return;
         }
+        const node* ptr = front;
+        do {
+            std::cout << ptr->data << ' ';
+            ptr = ptr->next;
+        } while (ptr != front);
+        std::cout << '\n';
     }
 };
 int main(void) {