Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shifted GLOBAL_ROUTE_ARGS definition to allow override #201

Conversation

jeffng-or
Copy link
Collaborator

No description provided.

@oharboe
Copy link
Collaborator

oharboe commented Nov 15, 2024

No suggestions as such, just some comments.

Perhaps time to bump ORFS? There has been some OpenROAD improvements in macros(check that OR is upgraded in ORFS recently before upgrading and bump OR in ORFS if not).

megaboom is there to run experiments using the CI and whatever we need to do to run todays experiments is fine to merge. Worst case we have the git history.

Also, I think it is fine to have some experiments only in PRs that are never merged as the code is just todays experiment and there is no reuse value as such.

GLOBAL_ROUTE_ARGS did not have "stages:" in variables.yaml at the time, so I had to add this to stage_arguments.

Note that you can easily support stage_arguments in SWEEP, though in the case of GLOBAL_ROUTE_ARGS it is moot.

@oharboe oharboe mentioned this pull request Nov 17, 2024
@oharboe
Copy link
Collaborator

oharboe commented Nov 18, 2024

With latest changes on main, I think this PR is moot. Close?

@jeffng-or jeffng-or closed this Nov 18, 2024
@jeffng-or jeffng-or deleted the enable-global-route-arg-override branch January 3, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants