Fix permission denied errors #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eryk Szpotanski <[email protected]>
Signed-off-by: Eryk Szpotanski <[email protected]>
Signed-off-by: Eryk Szpotanski <[email protected]>
oharboe
reviewed
Apr 16, 2024
| @@ -44,6 +44,9 @@ fi | |||
| export DESIGN_CONFIG_PREFIXED=$WORKSPACE_EXECROOT/$DESIGN_CONFIG | |||
| export STAGE_CONFIG_PREFIXED=$WORKSPACE_EXECROOT/$STAGE_CONFIG | |||
|
|
|||
| # Make bazel-bin writable | |||
| chmod -R +w $WORKSPACE_EXECROOT/bazel-out/k8-fastbuild/bin | |||
There was a problem hiding this comment.
It is a bit unnerving that files are overwritten in this folder. I something begin rebuilt that shouldn't?
| @@ -15,6 +15,9 @@ fi | |||
|
|
|||
| export WORK_HOME=$BUILD_DIR/$RULEDIR | |||
|
|
|||
| # Make bazel-bin writable | |||
| chmod -R +w $WORK_HOME | |||
There was a problem hiding this comment.
Hmm... OK for now, but it seems to me that this should be in the _make scripts. Are we hiding a more subtle problem?
|
@lpawelcz I am a little bit unnerved that we are hiding a real problem and making it harder to find later... Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the permission issues, which results in failing with
Permission erroror getting stuck with[...] overriding mode 0555 (r-xr-xr-x)?. It makes sure that files in workspace (bazel-bindirectory) are writable and can be overridden.