[DON'T MERGE] odb: add command to check if design is routed #5879
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eder Monteiro <[email protected]>
…ROAD into odb_is_routed Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
gadfort
reviewed
Oct 4, 2024
Signed-off-by: Eder Monteiro <[email protected]>
Yes, I'm working on it. I'm also testing it in the CI to check if I'm missing some check. |
|
clang-tidy review says "All clean, LGTM! 👍" |
eder-matheus
changed the title
gadfort
reviewed
Oct 6, 2024
Comment on lines
+4104
to
+4105
| if (pin_count > 1 && net->getSWires().empty() && net->getWire() == nullptr | ||
| && !net->isConnectedByAbutment()) { |
There was a problem hiding this comment.
if the SWires is not empty, you should probably verify that they actually have routing in them.
Same for getWire (ensure it actually contains something).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.