drt: getNestedIdx explicit output and curr_idx name changes #5862
Conversation
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
| const int idx_1 = flat_idx / idx_2_dim - 1; | ||
| const int idx_2 = flat_idx % idx_2_dim; | ||
| return {idx_1, idx_2}; |
There was a problem hiding this comment.
Any idea where there is a '-1' here? It seems non-idiomatic.
There was a problem hiding this comment.
Yes. This function is the reciprocal to getFlatIdx:
int FlexPA::getFlatIdx(const int idx_1, const int idx_2, const int idx_2_dim)
{
return ((idx_1 + 1) * idx_2_dim + idx_2);
}
The -1 inverts the +1 applied to idx_1. The +1, in turn, is there because the minimal value for idx_1 is -1, not 0. So the returned value will be always positive.
-1 is used as an argument for this function at genPatterns_reset, genPatternsInitand genInstRowPatternInit
There was a problem hiding this comment.
I actually don't like how the code keeps flattening and nesting these indexes, it happens a lot and some times one right after the other. If I find a way to eliminate it and keep a single representation for these indexes I will implement it.
|
Just understood what |
Signed-off-by: bernardo <[email protected]>
bnmfw
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Similar to #5778.
Changes
getNestedIdx()so its outputs are actual outputs instead of inputs passed by reference to be changed.Also changes instances of
curr_idx_1,curr_idx_2to eithercurr_pin_idx,curr_acc_point_idxorcurr_inst_idx,curr_acc_pattern_idxdepending on the appropriate use.
Similar changes were applied to variables with the same format that have
prevorprev_previnstead ofcurr.