Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drt: PA access pattern variable name changes #5858

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

drt: PA access pattern variable name changes #5858

wants to merge 1 commit into from
+35 −34

Conversation

bnmfw
Copy link
Contributor

@bnmfw bnmfw commented Oct 2, 2024 •
edited
Loading

As I was reading the Access Pattern of the PA module I noticed some variables still needed name changes. Here they are:

  • numNode → num_node
  • numEdge → num_edge
  • vioEdge → vio_edge
  • apIdx → ap_idx
  • via_2 → via2
  • via_1 → via1
  • leftAP → left_access_point (In Access Pattern it is important to differentiate Access Point from Access Patterns as both abbreviate to AP)
  • rightAP → right_access_point
  • leftPt → left_pt
  • rightPt → right_pt
  • tmpPt → tmp_pt

@bnmfw bnmfw added the drt Detailed Routing label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@bnmfw bnmfw marked this pull request as draft October 2, 2024 23:10
@bnmfw bnmfw marked this pull request as ready for review October 2, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osamahammad21 osamahammad21 Awaiting requested review from osamahammad21

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
drt Detailed Routing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bnmfw