-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpl2: adapt IO clusters to our flow #5809
Draft
AcKoucher
wants to merge
35
commits into
The-OpenROAD-Project:master
Choose a base branch
from
AcKoucher:mpl2-constraints
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
mpl2: adapt IO clusters to our flow #5809
AcKoucher
wants to merge
35
commits into
The-OpenROAD-Project:master
from
AcKoucher:mpl2-constraints
+711
−340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Koucher <[email protected]>
1) Remove logic of bundled ios per edge and add one constraint cluster per edge 2) Add checks to prevent crash - for testing 3) Comment blockages creation based on IO placement Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
1) map bterms when creating a new io cluster 2) remove debug check 3) cluster that represent no constraints have the shape of the die Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
…d SA Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
1) avoid computing WL twice for IO cases 2) add fixed penalty for IO connections when the macro is outside the outline 3) don't draw dist to edge in graphics when macro is outside the outline Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
…t boundary is blocked Signed-off-by: Arthur Koucher <[email protected]>
…ed to NONE Signed-off-by: Arthur Koucher <[email protected]>
…cked Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
… area and io clusters' extensions Signed-off-by: Arthur Koucher <[email protected]>
…blockages Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
…ment Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Signed-off-by: Arthur Koucher <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
AcKoucher
changed the title
mpl2: modify IO clusters to our flow
mpl2: adapt IO clusters to our flow
Sep 26, 2024
…ndaries Signed-off-by: Arthur Koucher <[email protected]>
AcKoucher
force-pushed
the
mpl2-constraints
branch
from
September 27, 2024 18:07
4255a1d
to
8543487
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Signed-off-by: Arthur Koucher <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ready, will resolve #4867 and close #5669.
Note: Opening as a draft, because there are regression tests to create.
Goals
Main Changes
Modify IO Clusters
IO clusters that represent bundledIOs created from the pins placed by random PPL are now groups of unplaced IOs with the same constraints based on the following:
Individual Pin Constraints:
Global Pins' Constraints (-exclude)
What Annealing Sees
Collateral Changes
Needed for the Approach to Work
Blockages for Pin Access
Generated based on a combination of both global and individual pins' constraints:
Orientation Improvement
When iterating a net, compute HPWL based on the center of the constraint region for each IO instead of its location.
Debug Mode