Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Carbon Dependency to Support Version 3.2.4 in jerome/filterable #3

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Thavarshan
Copy link
Owner

Summary:

This PR resolve #2 through updates the composer.json of the jerome/filterable package to allow compatibility with nesbot/carbon version 3.2.4. This change aims to resolve the version conflict issue when attempting to install jerome/filterable alongside the newer version of Carbon.

Background:

A dependency conflict occurs with nesbot/carbon when installing jerome/filterable, as the required version of Carbon is ^2.72 but many projects are now using Carbon 3.2.4. This update makes jerome/filterable compatible with the newer version of Carbon.

Changes:

  • Modified composer.json:
    • Updated the require section to allow nesbot/carbon versions ^2.72 or ^3.2.4.

Benefits:

  • Resolves dependency conflicts with nesbot/carbon.
  • Broader compatibility with projects using newer versions of Carbon.
  • Eases installation process for users with updated dependencies.

Testing:

  • Ensure that the package installs correctly when nesbot/carbon version 3.2.4 is present.
  • Run existing unit tests to verify that the update does not break any existing functionality.

Discussion Points:

  • Consideration for any potential breaking changes for users on older versions of Carbon.
  • Review of any other dependencies that might be affected by this change.

Additional Notes:

  • This PR does not include changes to the library's code but updates the dependency management.
  • Further testing may be required to ensure compatibility with other versions of dependencies.

@Thavarshan Thavarshan added bug Something isn't working enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Apr 10, 2024
@Thavarshan Thavarshan self-assigned this Apr 10, 2024
@Thavarshan Thavarshan merged commit 5fac35d into main Apr 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency Conflict with nesbot/carbon When Installing jerome/filterable
1 participant