Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(raycaster): correct variable naming in SimpleRaycaster constructor #126

Merged
merged 1 commit into from
Oct 6, 2023
Merged

refactor(raycaster): correct variable naming in SimpleRaycaster constructor #126

merged 1 commit into from
Oct 6, 2023

Conversation

lewibs
Copy link
Contributor

@lewibs lewibs commented Oct 2, 2023 •
edited
Loading

Description

The variable for a get from a raycaster was named scene. This should be raycaster.

Additional context

nothing was changed except name.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@oxcabe oxcabe changed the title typo(raycaster): renamed variable refactor(raycaster): correct variable naming in SimpleRaycaster constructor Oct 2, 2023
agviegas
agviegas approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@agviegas agviegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks a lot for the PR!

@agviegas agviegas merged commit d483d0d into ThatOpen:main Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agviegas agviegas agviegas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewibs @agviegas