fix(front): correct outliner disposal

ThatOpen · Oct 14, 2024 · 7c57c46 · 7c57c46
1 parent 20d2c59
commit 7c57c46
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/packages/front/package.json b/packages/front/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components-front",
   "description": "Collection of frontend tools to author BIM apps.",
-  "version": "2.3.4",
+  "version": "2.3.5",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

diff --git a/packages/front/src/fragments/Highlighter/example.ts b/packages/front/src/fragments/Highlighter/example.ts
@@ -144,6 +144,12 @@ stats.dom.style.zIndex = "unset";
 world.renderer.onBeforeUpdate.add(() => stats.begin());
 world.renderer.onAfterUpdate.add(() => stats.end());
 
+window.addEventListener("keydown", (e) => {
+  if(e.code === "KeyP") {
+    components.dispose();
+  }
+})
+
 /* MD
   ### 🎉 Wrap up
   ---

diff --git a/packages/front/src/fragments/Outliner/index.ts b/packages/front/src/fragments/Outliner/index.ts
@@ -27,8 +27,8 @@ export class Outliner extends OBC.Component implements OBC.Disposable {
 
   /** {@link OBC.Component.enabled} */
   set enabled(value: boolean) {
-    if (!this.world) {
-      throw new Error("Before enabling the outliner, provide a world!");
+    if (!this.world || this.world.isDisposing) {
+      return;
     }
 
     const renderer = this.getRenderer();
@@ -123,10 +123,12 @@ export class Outliner extends OBC.Component implements OBC.Disposable {
   /** {@link OBC.Disposable.dispose} */
 
   dispose() {
-    const styles = this.getStyles();
-    const styleNames = Object.keys(styles);
-    for (const name of styleNames) {
-      this.clearStyle(name, true);
+    if (this.world && !this.world.isDisposing) {
+      const styles = this.getStyles();
+      const styleNames = Object.keys(styles);
+      for (const name of styleNames) {
+        this.clearStyle(name, true);
+      }
     }
     this.onDisposed.trigger();
     this.onDisposed.reset();