fix(core): correct indexer bug skipping nested spatial elements

ThatOpen · Jul 23, 2024 · 13c92dd · 13c92dd
1 parent 086855d
commit 13c92dd
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components",
   "description": "Collection of core functionalities to author BIM apps.",
-  "version": "2.1.12",
+  "version": "2.1.13",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

diff --git a/packages/core/src/core/Components/index.ts b/packages/core/src/core/Components/index.ts
@@ -14,7 +14,7 @@ export class Components implements Disposable {
   /**
    * The version of the @thatopen/components library.
    */
-  static readonly release = "2.1.12";
+  static readonly release = "2.1.13";
 
   /** {@link Disposable.onDisposed} */
   readonly onDisposed = new Event<void>();

diff --git a/packages/core/src/ifc/IfcRelationsIndexer/index.ts b/packages/core/src/ifc/IfcRelationsIndexer/index.ts
@@ -118,7 +118,7 @@ export class IfcRelationsIndexer extends Component implements Disposable {
     const currentMap =
       relationsMap.get(relatingID) ?? new Map<number, number[]>();
     const index = this.getAttributeIndex(relating);
-    if (index) {
+    if (index !== null) {
       currentMap.set(index, relatedIDs);
       relationsMap.set(relatingID, currentMap);
     }
@@ -186,11 +186,18 @@ export class IfcRelationsIndexer extends Component implements Disposable {
 
     for (const relType of this._ifcRels) {
       const relsAttrs = await model.getAllPropertiesOfType(relType);
-      if (!relsAttrs) continue;
+      if (!relsAttrs) {
+        continue;
+      }
+
       const relInverseAttributes = this._relToAttributesMap.get(relType);
-      if (!relInverseAttributes) continue;
+      if (!relInverseAttributes) {
+        continue;
+      }
+
       const { forRelated: related, forRelating: relating } =
         relInverseAttributes;
+
       for (const expressID in relsAttrs) {
         const relAttrs = relsAttrs[expressID];
         this.indexRelations(relationsMap, relAttrs, related, relating);