Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo info helper script #667

Merged
merged 21 commits into from
Dec 7, 2022

Conversation

blazyy
Copy link
Contributor

@blazyy blazyy commented Nov 28, 2022

Added Python script used to help in finding a repository to fix flaky tests in. More info in README.md

repo-info/README.md Outdated Show resolved Hide resolved
repo-info/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@xieyt2000 xieyt2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it on my local machine and sometimes get 404 {"message": "Not Found", "documentation_url": "https://docs.github.com/rest/reference/repos#get-a-repository"}
Is this expected?

repo-info/requirements.txt Outdated Show resolved Hide resolved
repo-info/get_repo_info.py Outdated Show resolved Hide resolved
@blazyy
Copy link
Contributor Author

blazyy commented Nov 30, 2022

I ran it on my local machine and sometimes get 404 {"message": "Not Found", "documentation_url": "https://docs.github.com/rest/reference/repos#get-a-repository"} Is this expected?

This should only happen when a repository URL is not found. But after doing some manual testing, this is happening mainly on URLs that re-direct, URLs that don't point to the root of the repository, and occasionally, on completely fine URLs that don't re-direct, which is strange. Here is the list of URLs (from py-data.csv) that return an error:

https://github.com/AdventielFr/ecs-crd-cli.git
https://github.com/agile4you/bottle-neck.git
https://github.com/cbsinteractive/elemental.git
Cognexa/plcx#43
cronofy/pycronofy#72
dgilland/pydash#170
https://github.com/ElementAI/greensim
https://github.com/ferdinandvwyk/pyfilm.git
grd349/PBjam#265
hgrecco/pint#1412
laike9m/pdir2#58
https://github.com/macropin/django-registration/tree/master/registration
matheusbsilva/plai#34
Netflix-Skunkworks/policyuniverse#149
nithinmurali/pygsheets#519
osantana/prettyconf#47
https://github.com/Parsely/serpextract/
pyasi/pybuildkite#72
pydicom/pydicom#1540
raphaelvallat/pingouin#211
https://github.com/scikit-hep/scikit-hep/
swstephe/py2jdbc#8
verdan/pyatlasclient#12
voxpupuli/puppetboard#646
willvousden/ptemcee#16
ww-tech/primrose#113
yukinotenshi/pydeploy#5

@darko-marinov
Copy link
Contributor

Please rebase to the latest main so that we can run the checker.

@blazyy
Copy link
Contributor Author

blazyy commented Dec 2, 2022

@darko-marinov I'm new to rebasing so I'm pretty sure I messed it up. Please close this PR if I did. I will open a new one with the latest script changes.

@xieyt2000
Copy link
Contributor

@darko-marinov I'm new to rebasing so I'm pretty sure I messed it up. Please close this PR if I did. I will open a new one with the latest script changes.

Why do you think you messed it up? I think the changelist looks good now

@xieyt2000
Copy link
Contributor

I ran it on my local machine and sometimes get 404 {"message": "Not Found", "documentation_url": "https://docs.github.com/rest/reference/repos#get-a-repository"} Is this expected?

This should only happen when a repository URL is not found. But after doing some manual testing, this is happening mainly on URLs that re-direct, URLs that don't point to the root of the repository, and occasionally, on completely fine URLs that don't re-direct, which is strange. Here is the list of URLs (from py-data.csv) that return an error:

https://github.com/AdventielFr/ecs-crd-cli.git https://github.com/agile4you/bottle-neck.git https://github.com/cbsinteractive/elemental.git Cognexa/plcx#43 cronofy/pycronofy#72 dgilland/pydash#170 https://github.com/ElementAI/greensim https://github.com/ferdinandvwyk/pyfilm.git grd349/PBjam#265 hgrecco/pint#1412 laike9m/pdir2#58 https://github.com/macropin/django-registration/tree/master/registration matheusbsilva/plai#34 Netflix-Skunkworks/policyuniverse#149 nithinmurali/pygsheets#519 osantana/prettyconf#47 https://github.com/Parsely/serpextract/ pyasi/pybuildkite#72 pydicom/pydicom#1540 raphaelvallat/pingouin#211 https://github.com/scikit-hep/scikit-hep/ swstephe/py2jdbc#8 verdan/pyatlasclient#12 voxpupuli/puppetboard#646 willvousden/ptemcee#16 ww-tech/primrose#113 yukinotenshi/pydeploy#5

Yes this is strange. Can you try to debug it? It's fine if you can't solve it since the script works in most cases

@darko-marinov
Copy link
Contributor

Please update the code for the default branch name. Otherwise, as Yuntong said, this looks quite good, no problems with merge.

@blazyy
Copy link
Contributor Author

blazyy commented Dec 7, 2022

@darko-marinov Done with the requested changes

@darko-marinov darko-marinov merged commit 501ed48 into TestingResearchIllinois:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.