Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new flaky test added to pr-data.csv #1251

Conversation

anandk1999
Copy link
Contributor

No description provided.

@anandk1999 anandk1999 closed this Sep 8, 2024
@anandk1999 anandk1999 reopened this Sep 8, 2024
@anandk1999
Copy link
Contributor Author

#1252

@anandk1999
Copy link
Contributor Author

#1253

@Ajitesh27
Copy link

LGTM
Can you remove the formatting changes for the tests you didn't add?

@anandk1999
Copy link
Contributor Author

LGTM Can you remove the formatting changes for the tests you didn't add?

Which formatting changes are you referring to?

pr-data.csv Outdated
https://github.com/Adyen/adyen-java-api-library,6fb5cd049b57a22d2ec4465d204c15f1c90dd325,.,com.adyen.CheckoutTest.TestDateSerializers,ID,Accepted,https://github.com/Adyen/adyen-java-api-library/pull/681, A previous PR (https://github.com/Adyen/adyen-java-api-library/pull/654) was opened but not accepted because of adding a library
https://github.com/Adyen/adyen-java-api-library,6fb5cd049b57a22d2ec4465d204c15f1c90dd325,.,com.adyen.CheckoutTest.TestDokuDetailsSerialization,ID,Accepted,https://github.com/Adyen/adyen-java-api-library/pull/681, A previous PR (https://github.com/Adyen/adyen-java-api-library/pull/654) was opened but not accepted because of adding a library
https://github.com/Adyen/adyen-java-api-library,6fb5cd049b57a22d2ec4465d204c15f1c90dd325,.,com.adyen.CheckoutTest.TestDotpayDetailsSerialization,ID,Accepted,https://github.com/Adyen/adyen-java-api-library/pull/681, A previous PR (https://github.com/Adyen/adyen-java-api-library/pull/654) was opened but not accepted because of adding a library
https://github.com/Adyen/adyen-java-api-library,6fb5cd049b57a22d2ec4465d204c15f1c90dd325,.,com.adyen.CheckoutTest.TestAchDetailsSerialization,ID,Accepted,https://github.com/Adyen/adyen-java-api-library/pull/681," A previous PR (https://github.com/Adyen/adyen-java-api-library/pull/654) was opened but not accepted because of adding a library"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"" (quotes added) for some strings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. I'll remove the quotes, however, I didn't make these formatting changes, I think it might've been the command on the IDoFT repository to re-order the CSV file that might've made these changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, i've removed the formatting and committed and the csv file has passed the check!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@darko-marinov darko-marinov merged commit 712f96d into TestingResearchIllinois:main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants