Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pr-data.csv for Gaffer #1245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mukta13
Copy link

@Mukta13 Mukta13 commented Sep 5, 2024

No description provided.

@Mukta13 Mukta13 changed the title Update pr-data.csv Update pr-data.csv for Gaffer Sep 6, 2024
@Ajitesh27
Copy link

Please add some notes describing how you detected the new tests (e.g., commands that were run) and any necessary data to reproduce the detection (e.g., including the NonDex seed or flaky-list.json file for ID and OD tests, respectively). The specific format for the notes is described in Adding notes.

@Mukta13
Copy link
Author

Mukta13 commented Sep 9, 2024

This test was detected using the command: mvn edu.illinois:nondex-maven-plugin:2.1.7:nondex |& tee mp1-Gaffer-log-1.txt in the Gaffer repo. The logs on finding this flaky test was saved in the mp1-Gaffer-log-1.txt file which is:

mp1-gaffer-log-1.pdf

mp1-gaffer-log-1.pdf file contains the test failure logs which also has the information regarding the nondex seeds which might be helpful in reproducing this flaky test.

This test can be reproduced using these commands:

git clone https://github.com/gchq/Gaffer

cd Gaffer

git checkout 789a898ccc5db57226109233b22bb6b5180c46c0

mvn install -pl core/common-util -am -DskipTests

mvn -pl core/common-util edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=uk.gov.gchq.gaffer.commonutil.elementvisibilityutil.AuthorisationsTest#testToString

The failure test looks like this:

[ERROR] Failures:
[ERROR] AuthorisationsTest.testToString:117
Expecting actual's toString() to return:
"a,hijklmno,abcdefg"
but was:
"abcdefg,hijklmno,a"
[INFO]
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

@Mukta13
Copy link
Author

Mukta13 commented Sep 9, 2024

Please add some notes describing how you detected the new tests (e.g., commands that were run) and any necessary data to reproduce the detection (e.g., including the NonDex seed or flaky-list.json file for ID and OD tests, respectively). The specific format for the notes is described in Adding notes.

Hey Ajitesh. I have added more notes on this. Hope this helps. Thanks!

@Ajitesh27
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants