Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new ID flaky test found in Spring-Cloud-GCP repo #1244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jake-Zhi0Wang
Copy link

@Jake-Zhi0Wang Jake-Zhi0Wang commented Sep 4, 2024

This flaky test is found by nonDex, using mvn edu.illinois:nondex-maven-plugin:2.1.7:nondex

The config is following:

nondexFilter=.*
nondexMode=FULL
nondexSeed=933178
nondexStart=0
nondexEnd=9223372036854775807
nondexPrintstack=false
nondexDir=/home/jakew4/spring-cloud-gcp/spring-cloud-spanner-spring-data-r2dbc/.nondex
nondexJarDir=/home/jakew4/spring-cloud-gcp/spring-cloud-spanner-spring-data-r2dbc/.nondex
nondexExecid=4yhVOr8Ao2T36i9CJ+PiMRZe8x1P6BvMhUukstygnTQ=
nondexLogging=CONFIG
test=

The config file can be found here: mp1-nondex-config-2.txt

Click on to see more details on the error message when running this flaky test
[WARNING]  Parameter 'disableXmlReport' (user property 'disableXmlReport') is deprecated: No reason given
[INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQueryTests
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.808 s <<< FAILURE! -- in com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQueryTests
[ERROR] com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQueryTests.sortAndPageableQueryTest -- Time elapsed: 1.662 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 

expected: "SELECT *, ARRAY (SELECT AS STRUCT canceled, documentId, id, childId, content FROM documents WHERE (documents.id = children.id AND documents.childId = children.childId) AND (canceled = false)) AS documents FROM (SELECT * FROM children WHERE id = @id AND trader_id = @trader_id) children WHERE disabled = false ORDER BY trader_id ASC LIMIT 2 OFFSET 2"
 but was: "SELECT *, ARRAY (SELECT AS STRUCT documentId, id, childId, canceled, content FROM documents WHERE (documents.id = children.id AND documents.childId = children.childId) AND (canceled = false)) AS documents FROM (SELECT * FROM children WHERE id = @id AND trader_id = @trader_id) children WHERE disabled = false ORDER BY trader_id ASC LIMIT 2 OFFSET 2"
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
        at com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQueryTests.lambda$sortAndPageableQueryTest$4(SqlSpannerQueryTests.java:352)
        at com.google.cloud.spring.data.spanner.core.SpannerTemplate.queryAndResolveChildren(SpannerTemplate.java:640)
        at com.google.cloud.spring.data.spanner.core.SpannerTemplate.query(SpannerTemplate.java:265)
        at com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQuery.executeReadSql(SqlSpannerQuery.java:252)
        at com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQuery.executeRawResult(SqlSpannerQuery.java:210)
        at com.google.cloud.spring.data.spanner.repository.query.AbstractSpannerQuery.execute(AbstractSpannerQuery.java:63)
        at com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQuery.execute(SqlSpannerQuery.java:65)
        at com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQueryTests.sortAndPageableQueryTest(SqlSpannerQueryTests.java:373)
        at java.base/java.lang.reflect.Method.invoke(Method.java:569)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   SqlSpannerQueryTests.sortAndPageableQueryTest:373->lambda$sortAndPageableQueryTest$4:352 
expected: "SELECT *, ARRAY (SELECT AS STRUCT canceled, documentId, id, childId, content FROM documents WHERE (documents.id = children.id AND documents.childId = children.childId) AND (canceled = false)) AS documents FROM (SELECT * FROM children WHERE id = @id AND trader_id = @trader_id) children WHERE disabled = false ORDER BY trader_id ASC LIMIT 2 OFFSET 2"
 but was: "SELECT *, ARRAY (SELECT AS STRUCT documentId, id, childId, canceled, content FROM documents WHERE (documents.id = children.id AND documents.childId = children.childId) AND (canceled = false)) AS documents FROM (SELECT * FROM children WHERE id = @id AND trader_id = @trader_id) children WHERE disabled = false ORDER BY trader_id ASC LIMIT 2 OFFSET 2"
[INFO] 
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
[INFO] 

The steps to reproduce the issue:

mvn install -pl spring-cloud-gcp-data-spanner  -am -DskipTests

mvn -pl spring-cloud-gcp-data-spanner \
    test \
    -Dtest=com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQueryTests#sortAndPageableQueryTest

mvn -pl spring-cloud-gcp-data-spanner \
    edu.illinois:nondex-maven-plugin:2.1.7:nondex \
    -Dtest=com.google.cloud.spring.data.spanner.repository.query.SqlSpannerQueryTests#sortAndPageableQueryTest -DnondexRuns=10

The log output can be found here for your reference: mp1-nondex-log-2.txt

@Jake-Zhi0Wang Jake-Zhi0Wang changed the title add a new flaky test found in Spring-Cloud-GCP repo add a new ID flaky test found in Spring-Cloud-GCP repo Sep 4, 2024
@Ajitesh27
Copy link

Please add some notes describing how you detected the new tests (e.g., commands that were run) and any necessary data to reproduce the detection (e.g., including the NonDex seed or flaky-list.json file for ID and OD tests, respectively). The specific format for the notes is described in Adding notes.

@Jake-Zhi0Wang
Copy link
Author

Please add some notes describing how you detected the new tests (e.g., commands that were run) and any necessary data to reproduce the detection (e.g., including the NonDex seed or flaky-list.json file for ID and OD tests, respectively). The specific format for the notes is described in Adding notes.

Hey Ajitesh, I've added more details on the PR, hope that helps. Plz let me know if anything else is needed for the PR to be accepted. Thx

@Ajitesh27
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants