Skip to content

refactor: fix analyzer warnings (3) #2247

refactor: fix analyzer warnings (3)

refactor: fix analyzer warnings (3) #2247

Triggered via pull request January 12, 2025 19:28
Status Failure
Total duration 30m 29s
Artifacts 4

ci.yml

on: pull_request
Matrix: Unit tests
Mutation tests (Linux)
7m 9s
Mutation tests (Linux)
Mutation tests (Windows)
16m 49s
Mutation tests (Windows)
Static code analysis
13m 39s
Static code analysis
Publish Tests Results
29s
Publish Tests Results
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 16 warnings
Unit tests (ubuntu-latest)
[xUnit.net 00:00:04.69] Testably.Abstractions.Tests.TimeSystem.TimerTests.MockTimeSystemTests.Change_WithTimeSpan_ShouldResetTimer [FAIL]
Unit tests (ubuntu-latest)
All 2 tries failed: System.AggregateException: One or more errors occurred. (Process 'dotnet' exited with code 1. > /usr/share/dotnet/dotnet test /home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Tests/Testably.Abstractions.Tests.csproj --configuration Release --no-build --collect "XPlat Code Coverage" --results-directory /home/runner/work/Testably.Abstractions/Testably.Abstractions/TestResults --framework net6.0 --logger trx;LogFileName=Testably.Abstractions.Tests_net6.0.trx @ /home/runner/work/Testably.Abstractions/Testably.Abstractions Error output: [xUnit.net 00:00:04.69] Testably.Abstractions.Tests.TimeSystem.TimerTests.MockTimeSystemTests.Change_WithTimeSpan_ShouldResetTimer [FAIL] ) ---> Nuke.Common.Tooling.ProcessException: Process 'dotnet' exited with code 1. > /usr/share/dotnet/dotnet test /home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Tests/Testably.Abstractions.Tests.csproj --configuration Release --no-build --collect "XPlat Code Coverage" --results-directory /home/runner/work/Testably.Abstractions/Testably.Abstractions/TestResults --framework net6.0 --logger trx;LogFileName=Testably.Abstractions.Tests_net6.0.trx @ /home/runner/work/Testably.Abstractions/Testably.Abstractions Error output: [xUnit.net 00:00:04.69] Testably.Abstractions.Tests.TimeSystem.TimerTests.MockTimeSystemTests.Change_WithTimeSpan_ShouldResetTimer [FAIL] at Nuke.Common.Tooling.ProcessExtensions.AssertZeroExitCode(IProcess process) in /_/source/Nuke.Tooling/ProcessExtensions.cs:line 38 at Nuke.Common.Tooling.ToolTasks.<>c.<GetExitHandler>b__4_0(ToolOptions _, IProcess p) in /_/source/Nuke.Tooling/ToolTasks.ExitHandler.cs:line 27 at Nuke.Common.Tooling.ToolTasks.<>c__DisplayClass8_0.<GetExitHandlerInternal>b__3(ToolOptions o, IProcess p) in /_/source/Nuke.Tooling/ToolTasks.ExitHandler.cs:line 22 at Nuke.Common.Tooling.ToolTasks.Run[T](ToolOptions options) in /_/source/Nuke.Tooling/ToolTasks.Run.cs:line 36 at Nuke.Common.Tools.DotNet.DotNetTasks.DotNetTest(DotNetTestSettings options) in /_/source/Nuke.Common/Tools/DotNet/DotNet.Generated.cs:line 32 at Nuke.Common.Tooling.ConfigureExtensions.<>c__DisplayClass1_0`1.<Invoke>b__0(TOptions x) in /_/source/Nuke.Tooling/Configure.cs:line 38 at Nuke.Common.Tooling.ConfigureExtensions.<>c__DisplayClass3_0`2.<Invoke>b__0(TOptions x) in /_/source/Nuke.Tooling/Configure.cs:line 78 --- End of inner exception stack trace --- at Nuke.Common.Tooling.ConfigureExtensions.Invoke[TOptions,TResult](CombinatorialConfigure`1 configurator, Func`2 executor, Func`2 outputSelector, Int32 degreeOfParallelism, Boolean completeOnFailure) in /_/source/Nuke.Tooling/Configure.cs:line 91 at Nuke.Common.Tooling.ConfigureExtensions.Invoke[TOptions](CombinatorialConfigure`1 configurator, Func`2 executor, Int32 degreeOfParallelism, Boolean completeOnFailure) at Nuke.Common.Tools.DotNet.DotNetTasks.DotNetTest(CombinatorialConfigure`1 configurator, Int32 degreeOfParallelism, Boolean completeOnFailure) in /_/source/Nuke.Common/Tools/DotNet/DotNet.Generated.cs:line 36 at Build.Build.<get_DotNetUnitTests>b__57_1() in /home/runner/work/Testably.Abstractions/Testably.Abstractions/Pipeline/Build.UnitTest.cs:line 70
Unit tests (ubuntu-latest)
Target "DotNetUnitTests" has thrown an exception
Unit tests (ubuntu-latest)
Process completed with exit code 255.
Static code analysis
[xUnit.net 00:00:07.01] Testably.Abstractions.Tests.TimeSystem.TimerTests.MockTimeSystemTests.Change_WithLong_ShouldResetTimer [FAIL]
Static code analysis
Error during unit tests: System.AggregateException: One or more errors occurred. (Process 'dotnet' exited with code 1. > /usr/share/dotnet/dotnet test /home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Tests/Testably.Abstractions.Tests.csproj --configuration Release --no-build --collect "XPlat Code Coverage" --results-directory /home/runner/work/Testably.Abstractions/Testably.Abstractions/TestResults --framework net8.0 --logger trx;LogFileName=Testably.Abstractions.Tests_net8.0.trx @ /home/runner/work/Testably.Abstractions/Testably.Abstractions Error output: [xUnit.net 00:00:07.01] Testably.Abstractions.Tests.TimeSystem.TimerTests.MockTimeSystemTests.Change_WithLong_ShouldResetTimer [FAIL] ) ---> Nuke.Common.Tooling.ProcessException: Process 'dotnet' exited with code 1. > /usr/share/dotnet/dotnet test /home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Tests/Testably.Abstractions.Tests.csproj --configuration Release --no-build --collect "XPlat Code Coverage" --results-directory /home/runner/work/Testably.Abstractions/Testably.Abstractions/TestResults --framework net8.0 --logger trx;LogFileName=Testably.Abstractions.Tests_net8.0.trx @ /home/runner/work/Testably.Abstractions/Testably.Abstractions Error output: [xUnit.net 00:00:07.01] Testably.Abstractions.Tests.TimeSystem.TimerTests.MockTimeSystemTests.Change_WithLong_ShouldResetTimer [FAIL] at Nuke.Common.Tooling.ProcessExtensions.AssertZeroExitCode(IProcess process) in /_/source/Nuke.Tooling/ProcessExtensions.cs:line 38 at Nuke.Common.Tooling.ToolTasks.<>c.<GetExitHandler>b__4_0(ToolOptions _, IProcess p) in /_/source/Nuke.Tooling/ToolTasks.ExitHandler.cs:line 27 at Nuke.Common.Tooling.ToolTasks.<>c__DisplayClass8_0.<GetExitHandlerInternal>b__3(ToolOptions o, IProcess p) in /_/source/Nuke.Tooling/ToolTasks.ExitHandler.cs:line 22 at Nuke.Common.Tooling.ToolTasks.Run[T](ToolOptions options) in /_/source/Nuke.Tooling/ToolTasks.Run.cs:line 36 at Nuke.Common.Tools.DotNet.DotNetTasks.DotNetTest(DotNetTestSettings options) in /_/source/Nuke.Common/Tools/DotNet/DotNet.Generated.cs:line 32 at Nuke.Common.Tooling.ConfigureExtensions.<>c__DisplayClass1_0`1.<Invoke>b__0(TOptions x) in /_/source/Nuke.Tooling/Configure.cs:line 38 at Nuke.Common.Tooling.ConfigureExtensions.<>c__DisplayClass3_0`2.<Invoke>b__0(TOptions x) in /_/source/Nuke.Tooling/Configure.cs:line 78 --- End of inner exception stack trace --- at Nuke.Common.Tooling.ConfigureExtensions.Invoke[TOptions,TResult](CombinatorialConfigure`1 configurator, Func`2 executor, Func`2 outputSelector, Int32 degreeOfParallelism, Boolean completeOnFailure) in /_/source/Nuke.Tooling/Configure.cs:line 91 at Nuke.Common.Tooling.ConfigureExtensions.Invoke[TOptions](CombinatorialConfigure`1 configurator, Func`2 executor, Int32 degreeOfParallelism, Boolean completeOnFailure) at Nuke.Common.Tools.DotNet.DotNetTasks.DotNetTest(CombinatorialConfigure`1 configurator, Int32 degreeOfParallelism, Boolean completeOnFailure) in /_/source/Nuke.Common/Tools/DotNet/DotNet.Generated.cs:line 36 at Build.Build.<get_DotNetUnitTests>b__57_1() in /home/runner/work/Testably.Abstractions/Testably.Abstractions/Pipeline/Build.UnitTest.cs:line 70
API tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Mutation tests (Linux)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Unit tests (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Static code analysis
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(420,7): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(444,6): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(175,22): warning S3776: Refactor this method to reduce its Cognitive Complexity from 188 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(404,6): warning S1871: Either merge this branch with the identical one on line 396 or change one of the implementations. (https://rules.sonarsource.com/csharp/RSPEC-1871) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(305,7): warning S907: Remove this use of 'goto'. (https://rules.sonarsource.com/csharp/RSPEC-907) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(330,8): warning S907: Remove this use of 'goto'. (https://rules.sonarsource.com/csharp/RSPEC-907) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(335,7): warning S907: Remove this use of 'goto'. (https://rules.sonarsource.com/csharp/RSPEC-907) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(350,8): warning S907: Remove this use of 'goto'. (https://rules.sonarsource.com/csharp/RSPEC-907) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(354,7): warning S907: Remove this use of 'goto'. (https://rules.sonarsource.com/csharp/RSPEC-907) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(364,8): warning S907: Remove this use of 'goto'. (https://rules.sonarsource.com/csharp/RSPEC-907) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Publish Tests Results
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
API-tests
4.21 KB
Linux-artifacts
8.13 MB
Windows-artifacts
8.15 MB
macOS-artifacts
8.1 MB