Skip to content
CI

refactor: fix analyzer warnings (2) #2242

Sign in to view logs

refactor: fix analyzer warnings (2)

refactor: fix analyzer warnings (2) #2242

Triggered via pull request January 12, 2025 15:11
@vbreussvbreuss
synchronize #711
topic/fix-sonar-issues-2
Status Failure
Total duration 5m 19s
Artifacts –

ci.yml

on: pull_request
Matrix: Unit tests
API tests
2m 3s
API tests
Mutation tests (Linux)
1m 49s
Mutation tests (Linux)
Mutation tests (Windows)
4m 22s
Mutation tests (Windows)
Static code analysis
2m 32s
Static code analysis
Publish Tests Results
13s
Publish Tests Results
Fit to window
Zoom out
Zoom in

Annotations

28 errors and 20 warnings
Unit tests (macos-latest)
/Users/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/Users/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Unit tests (macos-latest)
/Users/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/Users/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Unit tests (macos-latest)
Target "Compile" has thrown an exception
Unit tests (macos-latest)
Process completed with exit code 255.
Unit tests (ubuntu-latest)
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Unit tests (ubuntu-latest)
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Unit tests (ubuntu-latest)
Target "Compile" has thrown an exception
Unit tests (ubuntu-latest)
Process completed with exit code 255.
Mutation tests (Linux)
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Mutation tests (Linux)
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Mutation tests (Linux)
Target "Compile" has thrown an exception
Mutation tests (Linux)
Process completed with exit code 255.
API tests
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
API tests
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
API tests
Target "Compile" has thrown an exception
API tests
Process completed with exit code 255.
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Tests/Testably.Abstractions.Testing.Tests/Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Static code analysis
Target "Compile" has thrown an exception
Static code analysis
Process completed with exit code 255.
Mutation tests (Windows)
D:\a\Testably.Abstractions\Testably.Abstractions\Tests\Testably.Abstractions.Testing.Tests\Statistics\StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [D:\a\Testably.Abstractions\Testably.Abstractions\Tests\Testably.Abstractions.Testing.Tests\Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Mutation tests (Windows)
D:\a\Testably.Abstractions\Testably.Abstractions\Tests\Testably.Abstractions.Testing.Tests\Statistics\StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [D:\a\Testably.Abstractions\Testably.Abstractions\Tests\Testably.Abstractions.Testing.Tests\Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Mutation tests (Windows)
Target "Compile" has thrown an exception
Mutation tests (Windows)
Process completed with exit code 1.
Unit tests (windows-latest)
D:\a\Testably.Abstractions\Testably.Abstractions\Tests\Testably.Abstractions.Testing.Tests\Statistics\StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [D:\a\Testably.Abstractions\Testably.Abstractions\Tests\Testably.Abstractions.Testing.Tests\Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Unit tests (windows-latest)
D:\a\Testably.Abstractions\Testably.Abstractions\Tests\Testably.Abstractions.Testing.Tests\Statistics\StatisticsTests.Helpers.cs(305,25): error CS0121: The call is ambiguous between the following methods or properties: 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' and 'Testably.Abstractions.Polyfills.StringExtensionMethods.IndexOf(string, char, System.StringComparison)' [D:\a\Testably.Abstractions\Testably.Abstractions\Tests\Testably.Abstractions.Testing.Tests\Testably.Abstractions.Testing.Tests.csproj::TargetFramework=net48]
Unit tests (windows-latest)
Target "Compile" has thrown an exception
Unit tests (windows-latest)
Process completed with exit code 1.
Unit tests (macos-latest)
No files were found with the provided path: ./Artifacts/* ./TestResults/*.trx. No artifacts will be uploaded.
Unit tests (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Unit tests (ubuntu-latest)
No files were found with the provided path: ./Artifacts/* ./TestResults/*.trx. No artifacts will be uploaded.
Mutation tests (Linux)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
API tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
API tests
No files were found with the provided path: ./Artifacts/* ./TestResults/*.trx. No artifacts will be uploaded.
Static code analysis
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs(513,52): warning S3011: Make sure that this accessibility bypass is safe here. (https://rules.sonarsource.com/csharp/RSPEC-3011) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.1]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs(601,52): warning S3011: Make sure that this accessibility bypass is safe here. (https://rules.sonarsource.com/csharp/RSPEC-3011) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.1]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs(605,55): warning S3011: Make sure that this accessibility bypass is safe here. (https://rules.sonarsource.com/csharp/RSPEC-3011) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.1]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Statistics/ParameterDescription.cs(66,6): warning S3060: Offload the code that's conditional on this type test to the appropriate subclass and remove the condition. (https://rules.sonarsource.com/csharp/RSPEC-3060) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.1]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Statistics/ParameterDescription.cs(80,10): warning S3060: Offload the code that's conditional on this type test to the appropriate subclass and remove the condition. (https://rules.sonarsource.com/csharp/RSPEC-3060) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.1]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Statistics/ParameterDescription.cs(89,6): warning S3060: Offload the code that's conditional on this type test to the appropriate subclass and remove the condition. (https://rules.sonarsource.com/csharp/RSPEC-3060) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.1]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Statistics/ParameterDescription.cs(98,6): warning S3060: Offload the code that's conditional on this type test to the appropriate subclass and remove the condition. (https://rules.sonarsource.com/csharp/RSPEC-3060) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.1]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Statistics/ParameterDescription.cs(106,6): warning S3060: Offload the code that's conditional on this type test to the appropriate subclass and remove the condition. (https://rules.sonarsource.com/csharp/RSPEC-3060) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.1]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Helpers/Execute.SimulatedPath.cs(716,20): warning S3776: Refactor this method to reduce its Cognitive Complexity from 41 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.1]
Static code analysis
/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Polyfills/FileSystemName.cs(420,7): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/Testably.Abstractions/Testably.Abstractions/Source/Testably.Abstractions.Testing/Testably.Abstractions.Testing.csproj::TargetFramework=netstandard2.0]
Unit tests (windows-latest)
No files were found with the provided path: ./Artifacts/* ./TestResults/*.trx. No artifacts will be uploaded.
Publish Tests Results
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Publish Tests Results
Could not find any files for artifacts/**/**/*.trx