Skip to content

Commit

Permalink
Various code cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
JC5 committed Sep 20, 2023
1 parent 6b5774a commit 7bf7bb5
Show file tree
Hide file tree
Showing 48 changed files with 344 additions and 80 deletions.
12 changes: 6 additions & 6 deletions .ci/php-cs-fixer/composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion app/Api/V2/Controllers/Chart/BalanceController.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

declare(strict_types=1);

/*
* BalanceController.php
* Copyright (c) 2023 [email protected]
Expand All @@ -21,6 +21,9 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);


namespace FireflyIII\Api\V2\Controllers\Chart;

use Carbon\Carbon;
Expand Down
4 changes: 3 additions & 1 deletion app/Api/V2/Controllers/Chart/BudgetController.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

declare(strict_types=1);

/*
* BudgetController.php
* Copyright (c) 2023 [email protected]
Expand All @@ -21,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Controllers\Chart;

use Carbon\Carbon;
Expand Down
6 changes: 4 additions & 2 deletions app/Api/V2/Controllers/Chart/CategoryController.php
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?php

declare(strict_types=1);

/*
* BudgetController.php
* CategoryController.php
* Copyright (c) 2023 [email protected]
*
* This file is part of Firefly III (https://github.com/firefly-iii).
Expand All @@ -21,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Controllers\Chart;

use Carbon\Carbon;
Expand Down
4 changes: 3 additions & 1 deletion app/Api/V2/Controllers/Model/Bill/ShowController.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

declare(strict_types=1);

/*
* ShowController.php
* Copyright (c) 2023 [email protected]
Expand All @@ -21,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Controllers\Model\Bill;

use FireflyIII\Api\V2\Controllers\Controller;
Expand Down
4 changes: 3 additions & 1 deletion app/Api/V2/Controllers/Model/PiggyBank/ShowController.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

declare(strict_types=1);

/*
* ShowController.php
* Copyright (c) 2023 [email protected]
Expand All @@ -21,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Controllers\Model\PiggyBank;

use FireflyIII\Api\V2\Controllers\Controller;
Expand Down
4 changes: 3 additions & 1 deletion app/Api/V2/Controllers/Model/Transaction/StoreController.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

declare(strict_types=1);

/*
* StoreController.php
* Copyright (c) 2023 [email protected]
Expand All @@ -21,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Controllers\Model\Transaction;

use FireflyIII\Api\V2\Controllers\Controller;
Expand Down
5 changes: 4 additions & 1 deletion app/Api/V2/Controllers/UserGroup/DestroyController.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?php


/*
* DestroyController.php
* Copyright (c) 2023 [email protected]
Expand All @@ -19,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Controllers\UserGroup;

use FireflyIII\Api\V2\Controllers\Controller;
Expand All @@ -28,5 +32,4 @@
*/
class DestroyController extends Controller
{

}
4 changes: 4 additions & 0 deletions app/Api/V2/Controllers/UserGroup/ShowController.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?php


/*
* ShowController.php
* Copyright (c) 2023 [email protected]
Expand All @@ -19,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Controllers\UserGroup;

use FireflyIII\Api\V2\Controllers\Controller;
Expand Down
6 changes: 6 additions & 0 deletions app/Api/V2/Controllers/UserGroup/StoreController.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?php


/*
* StoreController.php
* Copyright (c) 2023 [email protected]
Expand All @@ -19,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Controllers\UserGroup;

use FireflyIII\Api\V2\Controllers\Controller;
Expand Down Expand Up @@ -50,6 +54,8 @@ function ($request, $next) {
}

/**
* @param StoreRequest $request
*
* @return JsonResponse
*/
public function store(StoreRequest $request): JsonResponse
Expand Down
8 changes: 7 additions & 1 deletion app/Api/V2/Controllers/UserGroup/UpdateController.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?php


/*
* UpdateController.php
* Copyright (c) 2023 [email protected]
Expand All @@ -19,13 +21,17 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Controllers\UserGroup;

use FireflyIII\Api\V2\Controllers\Controller;

/**
* Class UpdateController
*/
class UpdateController extends Controller
{

// basic edit van group
// add user, add rights, remove user, remove rights.
}
7 changes: 6 additions & 1 deletion app/Api/V2/Request/Chart/BalanceChartRequest.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

declare(strict_types=1);

/*
* BalanceChartRequest.php
* Copyright (c) 2023 [email protected]
Expand All @@ -21,13 +21,18 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Request\Chart;

use FireflyIII\Support\Request\ChecksLogin;
use FireflyIII\Support\Request\ConvertsDataTypes;
use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Validation\Validator;

/**
* Class BalanceChartRequest
*/
class BalanceChartRequest extends FormRequest
{
use ConvertsDataTypes;
Expand Down
7 changes: 7 additions & 0 deletions app/Api/V2/Request/UserGroup/StoreRequest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?php


/*
* StoreRequest.php
* Copyright (c) 2023 [email protected]
Expand All @@ -19,12 +21,17 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Api\V2\Request\UserGroup;

use FireflyIII\Support\Request\ChecksLogin;
use FireflyIII\Support\Request\ConvertsDataTypes;
use Illuminate\Foundation\Http\FormRequest;

/**
* Class StoreRequest
*/
class StoreRequest extends FormRequest
{
use ChecksLogin;
Expand Down
16 changes: 10 additions & 6 deletions app/Console/Commands/System/OutputVersion.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

declare(strict_types=1);

/*
* OutputVersion.php
* Copyright (c) 2023 [email protected]
Expand All @@ -21,25 +21,29 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Console\Commands\System;

use Illuminate\Console\Command;

/**
* Class OutputVersion
*/
class OutputVersion extends Command
{
/**
* The name and signature of the console command.
* The console command description.
*
* @var string
*/
protected $signature = 'firefly-iii:output-version';

protected $description = 'Outputs the Firefly III version';
/**
* The console command description.
* The name and signature of the console command.
*
* @var string
*/
protected $description = 'Outputs the Firefly III version';
protected $signature = 'firefly-iii:output-version';

/**
* Execute the console command.
Expand Down
4 changes: 3 additions & 1 deletion app/Events/Model/Rule/RuleActionFailedOnArray.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

declare(strict_types=1);

/*
* RuleActionFailedOnArray.php
* Copyright (c) 2023 [email protected]
Expand All @@ -21,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Events\Model\Rule;

use FireflyIII\Models\RuleAction;
Expand Down
6 changes: 4 additions & 2 deletions app/Events/Model/Rule/RuleActionFailedOnObject.php
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?php

declare(strict_types=1);

/*
* RuleActionFailedOnArray.php
* RuleActionFailedOnObject.php
* Copyright (c) 2023 [email protected]
*
* This file is part of Firefly III (https://github.com/firefly-iii).
Expand All @@ -21,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Events\Model\Rule;

use FireflyIII\Models\RuleAction;
Expand Down
4 changes: 4 additions & 0 deletions app/Factory/UserGroupFactory.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?php


/*
* UserGroupFactory.php
* Copyright (c) 2023 [email protected]
Expand All @@ -19,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Factory;

use FireflyIII\Enums\UserRoleEnum;
Expand Down
4 changes: 3 additions & 1 deletion app/Handlers/Events/Model/RuleHandler.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

declare(strict_types=1);

/*
* RuleHandler.php
* Copyright (c) 2023 [email protected]
Expand All @@ -21,6 +21,8 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

declare(strict_types=1);

namespace FireflyIII\Handlers\Events\Model;

use FireflyIII\Events\Model\Rule\RuleActionFailedOnArray;
Expand Down
Loading

0 comments on commit 7bf7bb5

Please sign in to comment.