Show how to incorporate rollbar error handler in a TerriaMap instance #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyarsauce
suggested changes
Mar 26, 2020
| @@ -83,6 +84,10 @@ module.exports = terria.start({ | |||
| // new GnafSearchProviderViewModel({terria}) | |||
| ]; | |||
|
|
|||
| // viewState.errorHandler = new RollbarErrorProvider({ | |||
There was a problem hiding this comment.
In the instance of config being loaded from magda, have you checked whether configParameters correctly reflects the rollbarAccessToken after the terria.start call?
There was a problem hiding this comment.
(I would think that yes it does but i'm not 100%)
|
The ideal state for this would be that it gets loaded in if it detects an access token, so that you can change it with config without needing code change. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show how to support rollbar in a terriamap#mobx instance.
Reliant on TerriaJS/terriajs#4149 being merged.