Skip to content

Commit

Permalink
Improve wording and fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
steve9164 committed Jul 25, 2024
1 parent 3123a7a commit b64cdd2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions architecture/0002-docker-multi-arch-build.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ If instead we can (on the build machine/VM):
3. copy build artifacts and only production dependencies to the multi-arch
docker image

then **as long as production dependencies are portable**, we have very little
computation being run on emulated architectures. The `create-docker-context.js`
script allows us to do this, copying build artifacts and only production
dependencies to an intermediate "context" folder which is then used to create
the
then **as long as production dependencies are portable**, we have a working
multi-arch docker image with very little computation being run on emulated
architectures. The `create-docker-context.js` script allows us to do this,
copying build artifacts and only production dependencies to an intermediate
"context" folder which is then used to create the image.

Currently none of our production dependencies install non-portable binaries.

Expand Down
2 changes: 1 addition & 1 deletion deploy/docker/create-docker-context.js
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const argv = yargs
},
name: {
description:
"The package name to use in auto tag generation. Will default to ''. Used to override the docker nanme config in package.json during the auto tagging. Requires --tag=auto",
"The package name to use in auto tag generation. Will default to ''. Used to override the docker name config in package.json during the auto tagging. Requires --tag=auto",
type: "string",
default: process.env.MAGDA_DOCKER_NAME
},
Expand Down

0 comments on commit b64cdd2

Please sign in to comment.