Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common tags to basalt blocks #117

Merged
merged 1 commit into from
Aug 16, 2020

Conversation

Sturmlilie
Copy link
Contributor

For compatibility with TechReborn; see TechReborn/TechReborn#2091

@Prospector
Copy link
Member

I guess the one thing that makes this tricky is that in 1.16 we renamed basalt to Volcanic Rock to not conflict with vanilla's basalt. Not sure what exactly we should do here

@Sturmlilie
Copy link
Contributor Author

Hmm you're right, people will not get the connection that your volcanic rock grinds into basalt dust. At the same time vanilla is soon going to have more basalt than anyone can carry, with the caveat that it's only available via the nether.
Then again, anyone with REI installed can instantly find out what grinds into basalt dust.

@coderbot16
Copy link
Member

I think it would will be reasonable to treat volcanic rock like basalt even after the name change.

@coderbot16
Copy link
Member

It might still make sense to have Volcanic Rock grind into Basalt Dust still.

@coderbot16 coderbot16 reopened this Jul 11, 2020
@coderbot16 coderbot16 closed this Jul 11, 2020
@coderbot16
Copy link
Member

Uh, please disregard the above mess. I think this change makes sense, but it should probably be targeted on 1.16

@coderbot16 coderbot16 reopened this Jul 11, 2020
@NeusFear
Copy link
Member

@Sturmlilie would you mind updating this PR to 1.16, if not I'll go ahead and close the PR

For compatibility with TechReborn.
@Sturmlilie Sturmlilie changed the base branch from 1.15 to 1.16 July 23, 2020 15:29
@Sturmlilie
Copy link
Contributor Author

Tested with latest Tech Reborn for 1.16.1.

Copy link
Member

@coderbot16 coderbot16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change. Perhaps we could have a separate terrestria:volcanic_rock tag and then include that tag in the c:basalt tag, but that's not strictly needed.

@Sturmlilie
Copy link
Contributor Author

Just a heads up, there are problems with tags on latest MC versions. See: TechReborn/RebornCore#159

@NeusFear
Copy link
Member

@Sturmlilie is this just the in-dev issue?

@Sturmlilie
Copy link
Contributor Author

@NeusFear not sure what "in-dev" refers to; we've had multiple people hop on the TechReborn discord and report their Blockus compat being broken. It means that even if this PR gets merged, until the tag issue gets fixed, Terrestria basalt will presumably not be grindable in TR.

@NeusFear
Copy link
Member

in-dev means when launching the game from the development environment as opposed to using a built jar as a mod to the obfuscated game.

@NeusFear
Copy link
Member

I think it should be fine

@NeusFear NeusFear merged commit 207e59f into TerraformersMC:1.16 Aug 16, 2020
@Sturmlilie
Copy link
Contributor Author

in-dev means when launching the game from the development environment as opposed to using a built jar as a mod to the obfuscated game.

I pretty much never use this loom feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants