Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update checker promoting downgrades, other followup improvements #716

Merged
merged 3 commits into from
Jun 15, 2024

Conversation

LostLuma
Copy link
Contributor

Some improvements to my recent PRs:

  • Add version of available loader update to the update text (image)
  • Resolves Mod menu still keeps saying "Update Available" despite me downloading 3 stuff that were needed for the update #714 by checking whether the update Modrinth tells us about was released more recently than the one we're on
    • This should fix all cases except when people release updates out of order, but that seems unlikely
  • Changed the way update checker threads are created so we can use more lightweight virtual threads
    • This will need two changes on the 1.20.4 branch:
    • Create platform threads in the update checker thread factory
    • Use Executors.newCachedThreadPool instead of newThreadPerTaskExecutor, or whatever you prefer

Since we need to do two requests to the Modrinth API I've refactored the update checker to run these in parallel in their own threads (which is why I did pt. 3) so it is hopefully not any slower than before.

@LostLuma LostLuma marked this pull request as ready for review April 24, 2024 19:14
@Prospector Prospector merged commit 3b48ad5 into TerraformersMC:1.20.5 Jun 15, 2024
1 check passed
Prospector pushed a commit that referenced this pull request Jun 15, 2024
Prospector pushed a commit that referenced this pull request Jun 18, 2024
Prospector pushed a commit that referenced this pull request Jun 18, 2024
Prospector pushed a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants