-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playwright tests #650
Merged
Merged
playwright tests #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtwo
requested changes
Jun 22, 2024
There are 3 groups of queries.
1. Those with pop-up chat boxes or paragraphs with non-standard text that request API keys or other credentials to run. These will need to be tested manually.
2. Those with very long run times (could be 30 minutes). Those need to be on a separate automated test list that could be initiated manually. I would separate these to allow the rest of the notebook testing to have a reasonable run time and to prevent these notebooks with a questionable user experience be blended with the majority of the notebooks. There are 7 notebooks running over 1,000 seconds. The next 7 run between 350 and 600 seconds. There are 142 notebooks running less than 350 seconds.
3. Those with reasonable run times that should be tested any time we are making a Vantage software release change or a change to libraries
Dallas will need some documentation:
* How to add notebooks to the list to test
* Procedure for changing the requirements.txt and baking a new image in CI
* Initiating the test procedure in CI or in production.
Doug
From: Nitin s ***@***.***>
Sent: Sunday, June 23, 2024 1:27 PM
To: Teradata/jupyter-demos ***@***.***>
Cc: Ebel, Douglas H ***@***.***>; Review requested ***@***.***>
Subject: [EXTERNAL] Re: [Teradata/jupyter-demos] playwright tests (PR #650)
[CAUTION: External Email]
@sreeramnitin commented on this pull request.
________________________________
In .tests/tests/jupytertest.spec.ts<#650 (comment)>:
+const files = readFileIntoArray(FILE_NAME).filter((name) => skipfiles.indexOf(name) === -1);
+
+const testCount = Math.ceil(files.length / CSAE_CI_JOB_COUNT);
+
+for (let i = 0; i < testCount; i++) {
+ const idx = i * CSAE_CI_JOB_COUNT + CSAE_CI_JOB_IDX;
+ if(idx >= files.length) {
+ break;
+ }
+
+ const name = files[idx];
+ if(name === '') {
+ continue;
+ }
+ test(`test ${i}: ${name}`, async ({page},testInfo) => {
+ test.setTimeout(10800000);
There are some really long test. I have noted them and skipped for now. We can discus about them. Even Dough agreed that we do them manually.
-
Reply to this email directly, view it on GitHub<#650 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYNBXG3Z2HRZAYKSQ3UMQMLZI4AONAVCNFSM6AAAAABJWOMTGWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZUGM2TKNRXGM>.
You are receiving this because your review was requested.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playwright Smoke testing for the notebooks.
Skipping few files for following reasons.
Error in the execution
Requiring additional inputs from user
Pop up error dialogs
One or multiple steps taking to long to complete
Long running