Merge pull request #2322 from Teradata/knapsack/CJYXNrBVou

button implementation comparisons by Adam
Teradata · Jan 13, 2025 · f214079 · f214079
2 parents 0ecb148 + 4233e91
commit f214079
Show file tree

Hide file tree

Showing 24 changed files with 115 additions and 100 deletions.
diff --git a/apps/knapsack/data/blocks/block.6uCPA0GBmb.json b/apps/knapsack/data/blocks/block.6uCPA0GBmb.json
@@ -0,0 +1,18 @@
+{
+  "id": "6uCPA0GBmb",
+  "data": {
+    "items": [
+      {
+        "fileId": "KvXVAmYdCVAS7hzkOa73Em",
+        "nodeId": "14798:34543"
+      }
+    ],
+    "columns": "1",
+    "imageStyles": {
+      "fit": "fill",
+      "size": "large",
+      "seamless": true
+    }
+  },
+  "blockType": "design-src-tiles"
+}
diff --git a/apps/knapsack/data/blocks/block.93u7FVOSPJ.json b/apps/knapsack/data/blocks/block.93u7FVOSPJ.json
@@ -36,6 +36,7 @@
           "name": "Design principles",
           "path": "/pages/design-principles"
         },
+        "image": "https://knapsack.imgix.net/site/covalent/design-principles--H2sjXzMk74.png",
         "title": "Design principles"
       }
     ],

diff --git a/apps/knapsack/data/blocks/block.JPWqPNwNe.json b/apps/knapsack/data/blocks/block.JPWqPNwNe.json
diff --git a/apps/knapsack/data/blocks/block.RnLZOF1krl.json b/apps/knapsack/data/blocks/block.RnLZOF1krl.json
@@ -2,6 +2,15 @@
   "id": "RnLZOF1krl",
   "data": {
     "shortcuts": [
+      {
+        "id": "Lr4o2N0sC3",
+        "link": {
+          "name": "Design principles",
+          "path": "/pages/design-principles"
+        },
+        "image": "https://knapsack.imgix.net/site/covalent/foundationsdesign-principlesthumbnail--D5zNdIJECH.png",
+        "title": "Design principles"
+      },
       {
         "id": "OtxKkEX1FI",
         "link": {
@@ -11,15 +20,6 @@
         "image": "https://knapsack.imgix.net/site/covalent/color-zlgynxnkvpng",
         "title": "Color"
       },
-      {
-        "id": "e5vZWpD3an",
-        "link": {
-          "name": "Icons",
-          "path": "/pages/icons"
-        },
-        "image": "https://knapsack.imgix.net/site/covalent/icons-jochax2ppzpng",
-        "title": "Icons"
-      },
       {
         "id": "QfWJs0FvGa",
         "link": {
@@ -30,22 +30,30 @@
         "title": "Typography"
       },
       {
-        "id": "aAHr99CPu",
+        "id": "e5vZWpD3an",
+        "link": {
+          "name": "Icons",
+          "path": "/pages/icons"
+        },
+        "image": "https://knapsack.imgix.net/site/covalent/icons-jochax2ppzpng",
+        "title": "Icons"
+      },
+      {
+        "id": "M4AvsgGFap",
         "link": {
-          "name": "Voice and tone",
-          "path": "/pages/voice-and-tone"
+          "name": "Accessibility",
+          "path": "/pages/accessibility"
         },
-        "image": "https://knapsack.imgix.net/site/covalent/voice-and-tone-9drmogd1bpng",
-        "title": "Voice and tone",
-        "description": ""
+        "image": "https://knapsack.imgix.net/site/covalent/accessibility--9wTjMZheYM.png",
+        "title": "Accessibility"
       }
     ],
     "tileStyles": {
       "imageSize": "small",
       "titleSize": "large"
     },
     "gridStyles": {
-      "columns": "4"
+      "columns": "3"
     }
   },
   "blockType": "shortcut-tiles"

diff --git a/apps/knapsack/data/blocks/block.ZlOxs2iTGE.json b/apps/knapsack/data/blocks/block.ZlOxs2iTGE.json
diff --git a/apps/knapsack/data/blocks/block.asxSFBoEND.json b/apps/knapsack/data/blocks/block.asxSFBoEND.json
@@ -0,0 +1,18 @@
+{
+  "id": "asxSFBoEND",
+  "data": {
+    "items": [
+      {
+        "fileId": "KvXVAmYdCVAS7hzkOa73Em",
+        "nodeId": "14798:34745"
+      }
+    ],
+    "columns": "1",
+    "imageStyles": {
+      "fit": "fill",
+      "size": "auto",
+      "seamless": true
+    }
+  },
+  "blockType": "design-src-tiles"
+}
diff --git a/apps/knapsack/data/blocks/block.bkpqGQNuAN.json b/apps/knapsack/data/blocks/block.bkpqGQNuAN.json
@@ -123,7 +123,7 @@
                       },
                       "content": [
                         {
-                          "text": "A Primary Button is used for the main action on a page or screen, such as \"Submit\" or \"Save.\"",
+                          "text": "A primary button is used for the main action on a page or screen, such as \"submit\" or \"save\".",
                           "type": "text"
                         }
                       ]
@@ -186,7 +186,7 @@
                       },
                       "content": [
                         {
-                          "text": "A Secondary button is used for less critical actions or alternatives, like \"Cancel\" or \"Back.\"",
+                          "text": "A secondary button is used for less critical actions or alternatives, like \"cancel\" or \"back\".",
                           "type": "text"
                         }
                       ]
@@ -249,7 +249,7 @@
                       },
                       "content": [
                         {
-                          "text": "A Tertiary button is used for less critical actions or alternatives, like \"Cancel\" or \"Back.\" ",
+                          "text": "A tertiary button is used for less critical actions or alternatives, like \"cancel\" or \"back\". ",
                           "type": "text"
                         }
                       ]

diff --git a/apps/knapsack/data/blocks/block.h5DLbesybk.json b/apps/knapsack/data/blocks/block.h5DLbesybk.json
@@ -8,7 +8,7 @@
           "name": "Designers",
           "path": "/pages/designers"
         },
-        "image": "https://knapsack.imgix.net/site/covalent/get-started-designers-69jmv8kkrapng",
+        "image": "https://knapsack.imgix.net/site/covalent/get-started-designers--Yf1MXJjxUQ.png",
         "title": "Designers"
       },
       {
@@ -17,7 +17,7 @@
           "name": "Developers",
           "path": "/pages/developers"
         },
-        "image": "https://knapsack.imgix.net/site/covalent/get-started-developers-iynbusdnz6png",
+        "image": "https://knapsack.imgix.net/site/covalent/get-started-developers--liUrVKO53m.png",
         "title": "Developers"
       }
     ],

diff --git a/apps/knapsack/data/blocks/block.xAJ2NvEab.json b/apps/knapsack/data/blocks/block.xAJ2NvEab.json
@@ -28,5 +28,6 @@
       ]
     }
   },
-  "blockType": "text-editor"
+  "blockType": "text-editor",
+  "spacing": "large"
 }
diff --git a/apps/knapsack/data/db.yml b/apps/knapsack/data/db.yml
@@ -22,10 +22,10 @@ settings:
     files:
       - fileId: KvXVAmYdCVAS7hzkOa73Em
         name: Covalent principles
-        priorVersion: '2170958088646909198'
+        priorVersion: '2171352255511550622'
         type: figma
-        url: https://www.figma.com/file/KvXVAmYdCVAS7hzkOa73Em?version-id=2171768935539548668
-        version: '2171768935539548668'
+        url: https://www.figma.com/file/KvXVAmYdCVAS7hzkOa73Em?version-id=2173155024554587405
+        version: '2173155024554587405'
   favicon: https://knapsack.imgix.net/site/covalent/t-favicon-6zimud2smwpng
   hideTitleInNavigation: true
   logoUrl: https://knapsack.imgix.net/site/covalent/td-covalent-wordmark-sgyys2jeuwpng

diff --git a/apps/knapsack/data/demos/demo.CRFHBobaZj.json b/apps/knapsack/data/demos/demo.CRFHBobaZj.json
@@ -1,6 +1,6 @@
 {
   "id": "CRFHBobaZj",
-  "title": "Main",
+  "title": "Text",
   "type": "data",
   "patternId": "button",
   "templateId": "angular-i3OR9O7kXg",
@@ -11,8 +11,8 @@
     "slots": {
       "default": [
         {
-          "type": "text",
-          "text": "testing out this button"
+          "text": "Label",
+          "type": "text"
         }
       ]
     }

diff --git a/apps/knapsack/data/demos/demo.eIOsBgDEvJ.json b/apps/knapsack/data/demos/demo.eIOsBgDEvJ.json
@@ -1,12 +1,22 @@
 {
   "id": "eIOsBgDEvJ",
-  "title": "New Variation",
+  "title": "Raised",
   "description": "A description",
   "type": "data",
   "patternId": "button",
   "templateId": "angular-i3OR9O7kXg",
   "data": {
-    "props": {},
-    "slots": {}
+    "props": {
+      "color": "accent",
+      "raised": true
+    },
+    "slots": {
+      "default": [
+        {
+          "text": "Label",
+          "type": "text"
+        }
+      ]
+    }
   }
 }
diff --git a/apps/knapsack/data/knapsack.custom-page.design-principles.yml b/apps/knapsack/data/knapsack.custom-page.design-principles.yml
@@ -1,7 +1,7 @@
 id: design-principles
 title: Design principles
 blockIds:
-  - JPWqPNwNe
+  - 6uCPA0GBmb
   - 3kH6S7G1B
   - 5uPAVOsUif
   - uJcFZb7sP

diff --git a/apps/knapsack/data/knapsack.navs.yml b/apps/knapsack/data/knapsack.navs.yml
@@ -410,8 +410,9 @@ order:
   - foundations
   - design-principles
   - color
-  - icons
   - typography-3shrxwkyk
+  - icons
+  - accessibility
   - components
   - action-ribbon
   - alert
@@ -482,8 +483,7 @@ order:
   - video
   - date-and-time
   - word-list
-  - accessibility
+  - inclusive-language-glnk25tux
+  - get-started
   - designers
   - developers
-  - get-started
-  - inclusive-language-glnk25tux
diff --git a/apps/knapsack/data/knapsack.pattern.action-ribbon.json b/apps/knapsack/data/knapsack.pattern.action-ribbon.json
@@ -83,8 +83,8 @@
     {
       "id": "DGBIlJlEO",
       "type": "designSrc",
-      "minRoleNeeded": "ADMIN",
-      "hidden": true
+      "hidden": true,
+      "minRoleNeeded": "ADMIN"
     }
   ],
   "subPages": [

diff --git a/apps/knapsack/data/knapsack.pattern.button.json b/apps/knapsack/data/knapsack.pattern.button.json
@@ -170,7 +170,7 @@
       "id": "0KozkKiAif",
       "title": "Usage",
       "blockIds": [
-        "ZlOxs2iTGE",
+        "asxSFBoEND",
         "35GunJktxv",
         "bkpqGQNuAN",
         "xjDbfNDZ9",
@@ -214,7 +214,6 @@
       "id": "0KozkKiAif",
       "title": "Usage",
       "blockIds": [
-        "ZlOxs2iTGE",
         "35GunJktxv",
         "bkpqGQNuAN",
         "xjDbfNDZ9",
@@ -258,7 +257,6 @@
       "id": "0KozkKiAif",
       "title": "Usage",
       "blockIds": [
-        "ZlOxs2iTGE",
         "35GunJktxv",
         "bkpqGQNuAN",
         "xjDbfNDZ9",
@@ -302,7 +300,6 @@
       "id": "0KozkKiAif",
       "title": "Usage",
       "blockIds": [
-        "ZlOxs2iTGE",
         "35GunJktxv",
         "bkpqGQNuAN",
         "xjDbfNDZ9",

diff --git a/apps/knapsack/data/knapsack.pattern.checkbox.json b/apps/knapsack/data/knapsack.pattern.checkbox.json
@@ -61,7 +61,8 @@
     },
     {
       "id": "web-components-29FbeDQWhM",
-      "type": "template"
+      "type": "template",
+      "hidden": true
     },
     {
       "id": "RaQ2Ydmf11",

diff --git a/apps/knapsack/data/knapsack.pattern.dialog.json b/apps/knapsack/data/knapsack.pattern.dialog.json
@@ -117,7 +117,8 @@
     },
     {
       "id": "web-components-S9Ia0KOrya",
-      "type": "template"
+      "type": "template",
+      "hidden": true
     },
     {
       "id": "EPV5ONpvHo",

diff --git a/apps/knapsack/data/knapsack.pattern.focused-page.json b/apps/knapsack/data/knapsack.pattern.focused-page.json
@@ -48,12 +48,12 @@
   ],
   "tabs": [
     {
-      "type": "subPage",
-      "id": "oMAwFOtT2C"
+      "id": "oMAwFOtT2C",
+      "type": "subPage"
     },
     {
-      "type": "template",
-      "id": "web-components-waQVQEThJD"
+      "id": "web-components-waQVQEThJD",
+      "type": "template"
     }
   ],
   "subPages": [